search

OpenNews / opennews-source

Code refactor for Source, a website that spotlights work from the developers, designers, and data analysts at the intersection of journalism and tech: https://source.opennews.org
MIT License
5 stars 3 forks source link

Template integration: jobs_list #84

Closed ryanpitts closed 7 years ago

ryanpitts commented 7 years ago

OK, this one is 99% done and looking good, I think. @beep I hate to bug you about this, but I'm not sure why .icon-email is not working. Looks like the svg and png are in place and the css is there for it, but it's returning an empty image.

https://opennews-source-staging.herokuapp.com/jobs/

beep commented 7 years ago

@beep I hate to bug you about this

No worries at all, @ryanpitts, I’m more than happy to help! Holler at me any time.

I'm not sure why .icon-email is not working. Looks like the svg and png are in place and the css is there for it, but it's returning an empty image.

It’s returning an image, but annoyingly, it’s returning a white image. (And I love that browsers preview it on a ~white background.) I just created an alternate “dark” email icon email-alt.svg, which you can use with the icon-email-alt class, and tossed it into #88 for your review.

beep commented 7 years ago

Just as a point of interest: if we think we’ll need light and dark versions of most of our icons, grunticon has an option that allows us to embed icons directly in our pages, which lets us color/style them with CSS. (See the “Can I apply CSS to them?” section of grunticon.com.)

I think we’re good with the current approach right now, but we could look into that if we’ll need a fair bit of icon reuse across different kinds of backgrounds.

ryanpitts commented 7 years ago

It’s returning an image, but annoyingly, it’s returning a white image.

OMG I can't believe I didn't consider that. Thank you!

we could look into that if we’ll need a fair bit of icon reuse across different kinds of backgrounds.

I'm pretty sure that 95% of our use is going to be on the white background, but very good to know this is an option.

beep commented 7 years ago

OMG I can't believe I didn't consider that. Thank you!

Of course! (And dude no lie i do this at least five times over the course of any given week)

ryanpitts commented 7 years ago

@beep I have now grunt grunticon'd successfully. Oontz.

ryanpitts commented 7 years ago

@kissane this is ready for a final look I think. https://opennews-source-staging.herokuapp.com/jobs/

kissane commented 7 years ago

Looks awesome, forgot to say that