search

OpenNews / opennews-source

Code refactor for Source, a website that spotlights work from the developers, designers, and data analysts at the intersection of journalism and tech: https://source.opennews.org
MIT License
5 stars 3 forks source link

Bio field population for articles #94

Closed kissane closed 7 years ago

kissane commented 7 years ago

On article pages, is it possible to pull in Twitter bios to populate the bio area at the bottom if the real "Bio" field is blank on a Person record? Is that a huge pain?

ryanpitts commented 7 years ago

We can, it's not a pain at all. (We also store references to people's Twitter avatars btw.) My concern is over any Twitter TOS stuff this might run afoul of. I think we might be OK using those as fallbacks, but @kissane how do you read stuff like this?

kissane commented 7 years ago

Hmmmmmmm.

I don't think it's super clear. Safest thing would be to not do it BUT my inclination is to plonk in the bios and photos for now as fallbacks and then continue on our effort to replace them. Do you have gut feelings?

ryanpitts commented 7 years ago

same gut as you about the safest thing, but also agree on the lack of clarity. Let's try the fallback method

kissane commented 7 years ago

Awesome. Is it tempting fate to use those photos on the People list page?

ryanpitts commented 7 years ago

seems like a lot of people use the same avatar pic in a lot of places, so ...

ryanpitts commented 7 years ago

Hmm, so what we are storing is a reference to avatar images like so: https://pbs.twimg.com/profile_images/819655398923898881/WqEggJd0_normal.jpg

probably not OK for us to call those in directly

kissane commented 7 years ago

Yeeeeah nope. Ah, well, it was a nice thought.

ryanpitts commented 7 years ago

OK, article pages will now fall back to an author's twitter bio if no Source bio exists. (Same behavior as on the person pages)

kissane commented 7 years ago

Thank you!

kissane commented 7 years ago

Fix confirmed, closing