OpenNewsLabs / autoEdit_2

Fast text based video editing, node Electron Os X desktop app, with Backbone front end.
https://opennewslabs.github.io/autoEdit_2/
MIT License
420 stars 56 forks source link

EDL drifting out of sync #26

Open pietrop opened 7 years ago

pietrop commented 7 years ago

As raised by one of the users when exporting an EDL file (paraphrasing)

for videos longer than 15 minutes it starts drifting out a sync of 30 to 20 seconds. In recognising the in and out points of the video in the EDL. Losing Accuracy.

To reproduce this issue Get a video file NTSC, 30fps

  1. Add video to autoEdit
  2. Get a transcription
  3. Scroll towards the end of the transcription and select one of the last lines
  4. export EDL and reconnect in premiere (or other editing software of choice)
  5. When reconnecting sequence chose NTSC, 30fps in the sequence.
  6. See if the video segment correspond to the text selection in the app.

If bug occur, expecting it to drift of and not be same selection.

Further test. with same EDL file.

  1. import in premiere, but this time when chosing sequence settings chose PAL 25fps
  2. See if the video segment correspond to the text selection in the app.

From previous tests expecting the text selection in the app to match video segments in the EDL sequence using when choosing PAL and 25fps

Considerations

The timecode module used in the EDL composer has a default setting on 25fps.

Possible fix

Allow to pass in fps to timecode as a variable and give the user the option to export the EDL as a NTSC sequence?

Need to look more into how timecodes and PAL/NTSC work.

pietrop commented 7 years ago

Note, NTSC is actually 29.97fps not 30.

pietrop commented 7 years ago

I tried this, with the node-timecodes module in terminal

> var timecodes = require('node-timecodes');
undefined
> timecodes.fromSeconds(1427.4);
'00:23:47:10'
> timecodes.fromSeconds(1427.4, {frameRate: 29.97});
'00:23:47:NaN'

There might be an issue with the fromSeconds function. Raised as an issue here

pietrop commented 7 years ago

See issue 25 for example.

pietrop commented 7 years ago

Hypothesis is that it drifts because of PAL vs NTSC frame rate differece. in autoEdit, it's default to PAL.

Possible test/solution is

pietrop commented 7 years ago

Figured it out, if I add an optional frame rate to the EDL module, make selection, export EDL, and then connect as NTSC the sequence in premiere works with no drift.

timecodes.fromSeconds(this.tapeIn, {frameRate: 29.97}) 

so next step to fix this are

Then test it out again.