OpenNewsLabs / autoEdit_2

Fast text based video editing, node Electron Os X desktop app, with Backbone front end.
https://opennewslabs.github.io/autoEdit_2/
MIT License
419 stars 56 forks source link

does autoEdit2 use the X-Watson-Learning-Opt-Out true header for Watson transcriptions? #43

Open pietrop opened 6 years ago

pietrop commented 6 years ago

As originally raised by @Riptwo on twitter.

does autoEdit2 use the X-Watson-Learning-Opt-Out true header for Watson transcriptions?

Shotr answer:

No.

Long answer:

It uses the watson-developer-cloud node module. But I haven't specified that option (I think maybe it wasn't around when I first did it)

I see now it has been added as an option in the SDK node module

At the moment as mentioned there, by default all request are logged

Possible fix:

To implement, it be a matter of adding

var myInstance = new watson.WhateverServiceV1({
  /* username, password, version, etc... */
  headers: {
    "X-Watson-Learning-Opt-Out": true
  }
});

Where the Watson STT instance is initialised changing it as follows to add the headers informations.

  speech_to_text = watson.speech_to_text({
        username: keys.username,
        password: keys.password,
        version: 'v1',
        headers: {
                 "X-Watson-Learning-Opt-Out": true
              }
      });

Things to think about for integration (ie going beyond hard coding a solution):

In the UI/UX It would also be good to add this as an option when creating the transcription, or in the settings where the credentials are added to give more fine grained control to the user on whether to opt in or out, rather then hard coding it.

Help and feedback wanted.