OpenNewsLabs / autoEdit_2

Fast text based video editing, node Electron Os X desktop app, with Backbone front end.
https://opennewslabs.github.io/autoEdit_2/
MIT License
420 stars 56 forks source link

Cannot export SRT second time #47

Closed sedubois closed 5 years ago

sedubois commented 6 years ago

After exporting SRT subtitles a first time with Transcriptions > Export > Captions, the button doesn't do anything anymore when trying to export a second time. The same behavior does not occur e.g when exporting EDLs. I don't know any workaround. Using macOS 1.0.10.

pietrop commented 6 years ago

Hi @sedubois I couldn’t reproduce the issue on my end.

Which version of autoEdit are you using? Try latest 1.0.10 if you are not already on it.

https://github.com/OpenNewsLabs/autoEdit_2/releases/tag/1.0.10

When that happens,Could you take a screenshot of the console and share it here in case there are any error?

Cmd + alt + j should open the console in autoEdit

If it helps, I prototyped another app for making subitiling easier and faster, that I plan to integrate with autoEdit at some point.

https://github.com/pietrop/subtitlesComposer-app

See user manual for more details

https://pietropassarelli.gitbooks.io/subtitlecomposer-app/content/

You could export plain text ( no timecodes) from autoEdit, proofread, and then make subtitles with subutilesComposer, which will do the realignment ( very fast) and create a subtitle file with timecodes.

Let me know how it goes

sedubois commented 6 years ago

Thanks @pietrop, as indicated I'm on macOS using autoEdit2 version 1.0.10. What does Cmd+alt+j mean on a mac keyboard? I tried option-cmd-j and ctrl-cmd-j to no avail.

Also the subtitlesComposer-app looks really promising, but after installing it + the aeneas aligner, I didn't get it working: after clicking "create subtitle" it keeps showing "processing..." even after 10 minutes. Is there some debug console to look at?

Extra notes about subtitlesComposer:

Thanks!

pietrop commented 6 years ago

@sedubois sorry, it's Cmd+alt+i to open the console in autoEdit (same command as to open the inspector in chrome)

if you can replicate the error, and upload a screenshot here, of the error logs in the console, I can get a better sense of what's causing the issue.

re-subtitlesComposer

sedubois commented 6 years ago

OK great, that works. Here's the stack trace:

Uncaught TypeError: Cannot read property 'startTime' of undefined
    at file:///Applications/autoEdit2.app/Contents/Resources/app/electron/app.js:477:68
    at Array.forEach (native)
    at file:///Applications/autoEdit2.app/Contents/Resources/app/electron/app.js:458:30
    at Array.forEach (native)
    at loopThroughStuff (file:///Applications/autoEdit2.app/Contents/Resources/app/electron/app.js:457:12)
    at Function.returnSrtContent (file:///Applications/autoEdit2.app/Contents/Resources/app/electron/app.js:491:5)
    at child.expoertCaptionsSrt (file:///Applications/autoEdit2.app/Contents/Resources/app/electron/app.js:2871:49)
    at HTMLDivElement.dispatch (file:///Applications/autoEdit2.app/Contents/Resources/app/electron/app.js:13396:27)
    at HTMLDivElement.elemData.handle (file:///Applications/autoEdit2.app/Contents/Resources/app/electron/app.js:13048:28)
pietrop commented 6 years ago

Thanks for the error log,

re-subtitle composer, I've added a new version, which I tested locally and seemed to work fine, see if it works for you.

https://github.com/pietrop/subtitlesComposer-app/releases/tag/1.0.2

Not quiet sure what it's causing that error, need more time to look into it..

pietrop commented 6 years ago

@sedubois do you still have this issue with exporting srt? I couldn't reproduce the issue in autoEdit...

sedubois commented 6 years ago

@pietrop I checked and still have it with my autoEdit2 1.0.10 on mac. I open a transcription, click export > Captions - srt --> it works I get the file saving popup. I cancel, then click the Captions - srt button again then get the error shown above (https://github.com/OpenNewsLabs/autoEdit_2/issues/47#issuecomment-390467057).

pietrop commented 5 years ago

👋 @sedubois Just tested on 1.0.16 and was able to export caption twice in a row, but feel free to reopen if you are still experience this issue in the latest version.