search

OpenNuvoton / NUC970_U-Boot_v2016.11

U-Boot v2016.11 for NUC970, N9H30, and NUC980
28 stars 45 forks source link

Nuvoton I2C speed settings inconsistent with other devices #8

Closed lightelf76 closed 5 years ago

lightelf76 commented 5 years ago

NUC970 driver measure I2C speed in kHz, where most other SoC uses value in Hz.

yachen commented 5 years ago

Yup, you're right. Do you want to send a pull request? Or we can update the code by our engineer.

Sincerely,

Yi-An Chen

lightelf76 commented 5 years ago

I am thinking how to do it without disturbing existing customers. By the way, I started N32926 support for one of old projects.

yachen commented 5 years ago

Hi,

NUC970 TRM states “Only 100kbps and 400kbps modes are supported directly in this chip.” So seeing anything below 1000, the driver can assume the unit is kHz, otherwise it’s Hz. This should minimize the impact to existing customers those are using I2C function in U-Boot.

Sincerely,

Yi-An Chen

=========================================================================================== The privileged confidential information contained in this email is intended for use only by the addressees as indicated by the original sender of this email. If you are not the addressee indicated in this email or are not responsible for delivery of the email to such a person, please kindly reply to the sender indicating this fact and delete all copies of it from your computer and network server immediately. Your cooperation is highly appreciated. It is advised that any unauthorized use of confidential information of Nuvoton is strictly prohibited; and any information in this email irrelevant to the official business of Nuvoton shall be deemed as neither given nor endorsed by Nuvoton.

lightelf76 commented 5 years ago

Done! Please see pull request

yachen commented 5 years ago

Pulled. Thanks.