OpenNyAI / Jugalbandi-Manager

Jugalbandi (JB) Manager is a full AI-powered conversational chatbot platform. It's platform agnostic and can serve multiple channels such as WhatsApp or custom web interfaces. It can handle conversations in both text and voice across any language. It comes with Bhashini Speech models out of the box and can failover to Azure.

https://docs.jugalbandi.opennyai.org/

Apache License 2.0

23 stars 30 forks source link

Re: Support for cloud storage connectors #172 #184

Closed shreyp135 closed 1 month ago

shreyp135 commented 3 months ago

178

Added cloud storage connectors(sync and async) for aws and gcp. Added tests for aws and gcp. Added required env variables in the env template file. Made changes according to the tests.

shreyp135 commented 3 months ago

Hi @KaranrajM I have created a new pull request after necessary changes, all tests are passing except the google metadata access in gcp test. I am guessing that is specific to my system & network config. Please check once.

KaranrajM commented 3 months ago

Hi @shreyp135 there are two test cases (test_write_file, test_download_file_to_temp_storage) failing for me as well. Please fix them. Also remove unnecessary imports from all the files which will clean up the code. Have you tested these GCP and AWS code with their actual keys just to check whether the code is working?

shreyp135 commented 3 months ago

Hi @KaranrajM, I am stuck on this error, although my account is verified and billing is linked to the project these errors are persistent. Could you please help me in this ?

KaranrajM commented 3 months ago

Hi @KaranrajM, I am stuck on this error, although my account is verified and billing is linked to the project these errors are persistent. Could you please help me in this ?

Can you try mocking the calls and pass the test cases? Also please do the suggested other changes as well. Have you tested this packages with your actual GCP and AWS keys to test storage functionalities?

shreyp135 commented 2 months ago

Hi @KaranrajM, I finally got all the test passing but while testing with actual keys, there is an authentication issue but I am assuming that is specific to my billing account.

KaranrajM commented 2 months ago

Hi @shreyp135 I have left some comments, I tried running the gcp files with my keys, they were throwing errors. Please check them from ur side and once every storage function in GCP and AWS is running and working, we can close this PR

Lekhanrao commented 2 months ago

@shreyp135, any updates here please? Also this PR is for Issue #172 and not 178!

shreyp135 commented 2 months ago

@shreyp135, any updates here please? Also this PR is for Issue #172 and not 178!

Hi @Lekhanrao, Sorry but I am not able to debug the errors that are persistent, but I believe that others are also working on this issue so this PR can be a good head start for them.

KaranrajM commented 1 month ago

Closing this PR. This PR is used for reference for future works. Thanks @shreyp135 for all the works you did here.