search

OpenNyAI / Jugalbandi-Manager

Jugalbandi (JB) Manager is a full AI-powered conversational chatbot platform. It's platform agnostic and can serve multiple channels such as WhatsApp or custom web interfaces. It can handle conversations in both text and voice across any language. It comes with Bhashini Speech models out of the box and can failover to Azure.
https://docs.jugalbandi.opennyai.org/
Apache License 2.0
23 stars 30 forks source link

added the aws and gcp connectors #187

Open Ris-code opened 3 months ago

Ris-code commented 3 months ago

Fix for - #173

KaranrajM commented 3 months ago

Hi @Ris-code can you add these env variables in docker-compose.yaml under language service? Also can you please add these necessary GCP and AWS packages to pyproject.toml file by using poetry add command.

I hope the packages are tested with keys and its working. Rest of the code looks good.

Ris-code commented 3 months ago

Hi @Ris-code can you add these env variables in docker-compose.yaml under language service? Also can you please add these necessary GCP and AWS packages to pyproject.toml file by using poetry add command.

I hope the packages are tested with keys and its working. Rest of the code looks good.

Ok, will do it by today.

Ris-code commented 3 months ago

Hi @KaranrajM , I have added the env variables as well as updated the pyproject.toml . Please review it once.

KaranrajM commented 3 months ago

Hi @Ris-code I have left some new reviews for the latest commit. Please take a look and make the required changes when you can.

Ris-code commented 3 months ago

Hi @Ris-code I have left some new reviews for the latest commit. Please take a look and make the required changes when you can.

Sure.

Ris-code commented 3 months ago

Hi @Ris-code I have left some new reviews for the latest commit. Please take a look and make the required changes when you can.

I could not find any review. Could you please assist me where it is?

KaranrajM commented 3 months ago

Hi @Ris-code I have left some new reviews for the latest commit. Please take a look and make the required changes when you can.

I could not find any review. Could you please assist me where it is?

You can see them at the top when you open this PR conversation. Let me tag you in those comments.

sameersegal commented 2 months ago

@shreypandey please review the changes here

Ris-code commented 2 months ago

@KaranrajM I have done the changes. Please review them once.

VedantKhairnar commented 2 months ago

Hello @Ris-code Will you pls check the PR-Issue linking guidelines and make the changes accordingly in the PR description(need to mention the Issue number). This helps in efficient progress tracking. Thanks.

Ris-code commented 2 months ago

@KaranrajM I have done all the mentioned changes and tested after mounting the GCP credentials during runtime. Please review all the changes.

KaranrajM commented 1 month ago

Hi @Ris-code I have tried to build a docker-image of language using this code, it throws an error when GOOGLE_APPLICATION_CREDENTIALS is empty in .env-dev. Can you handle this case as well as people mostly use either of the three services (Azure or AWS or GCP) not all of them? So we need to handle the case of gcp not being used then the volume should not be mounted in docker-compose.yml if the GOOGLE_APPLICATION_CREDENTIALS is not set. Rest of the code looks good. Please fix the docker-compose.yml change so this code can be merged. Let me know if you need any help.