search

OpenObservatory / ooni-pipeline.backup

[DEPRECATED] This is the ooni pipeline for doing data analytics on the collected reports
8 stars 6 forks source link

Fix bug 13655 #13

Closed oripka closed 9 years ago

hellais commented 9 years ago

Awesome good stuff!

The only thing that needs to be added is the same filtering logic and checking for adding the tcp_connect field and then it should be all set to be merged.

oripka commented 9 years ago

Please take a look at the code above. It merges the two bugs 13640 and 13655. It also now correlates tcp connect and bridge measurements using the hashed fingerprint (it used to be done using the probe AS number, I am not sure what was the logic behind this). Using the hashed fingerprint we now can now output the information if a tcp connect measurement for the input bridge was successfull.

hellais commented 9 years ago

The reason why we did the check for the ASN is that the tcp connect test we are interested in connecting to the measurement in question are the ones that are performed from the same vantage point (hence have the same ASN) and were for the given input.

That checks needs to stay there as you will not find any tcp connect measurements being done from the control country (NL).

oripka commented 9 years ago

Ok, I'm going to do a new pull request to merge this into one commit