OpenOrienteering / mapper

OpenOrienteering Mapper is a software for creating maps for the orienteering sport.
https://www.openorienteering.org/apps/mapper/
GNU General Public License v3.0
402 stars 106 forks source link

Indicate insufficient dimension of lines and areas during editing #1021

Open ollesmaps opened 6 years ago

ollesmaps commented 6 years ago

It would be cool if minimum dimensions for areas and lines could be predefined.

For example ISOM2017 minimum dimension for 406 Vegetation, slow running is 225 m2. If this area symbol is drawn and is bellow limit it could be somehow highlighted it is bellow minimum dimensions. The highlight changes only when area is over minimum dimension.

Ideas for highligting:

The minimum dimension could be built in within each symbol definition. With that it could be possible to perform more easily an overall checkup of finished map. Something like http://oapp.se/Applikationer/CheckOMap.html

dg0yt commented 6 years ago

Do you sometimes use the desktop version? We already do have minimal dimensions. However, they are only used in the "measurement" window at the moment.

The strict way of enforcement would be to NOT show the object (apart from placeholder in a different color). I can hear the outcry when you cannot draw a "narrow ride" below minimal length - people take for granted what they are used to from other products ;-)

ollesmaps commented 6 years ago

You are right (now I see it on desktop, most of the time I use the app ) there is a minimum size option. And it shows up when measured. That is great.

I agree a strict enforcement would be too strict. I would prefer a highlight that shows up already during drawing. This way you can adjust your mapping straight away and do not have to make time costly check ups at the end.

lpechacek commented 6 years ago

I myself would be happy for an automated checker checking minimum lengths, areas and gaps. Given enough programmers, the first two are trivial to implement. For the third one I do have some idea. Code contributors wanted! :)

@ollesmaps Another possibility would be to persuade CheckOMap author to extend the tool with OO Mapper format support.

dg0yt commented 6 years ago

Another option would be to add this as a special feature/keyword to the "Find" dialog. This gives you both "Find all" and step-by-step.

dg0yt commented 6 years ago

Previous tickets: #35 Problem widget, #302 Map report and problem browser tool, #651"Minimal length" of linear symbols.

ollesmaps commented 6 years ago

Relates to: http://orienteering.org/new-control-process-for-mapping-for-iof-events/

ollesmaps commented 6 years ago

Or it can change symbol icon background color when object is being edited - if under limit highlighted color, if ok as usuall. color_symbol

mlerjen commented 6 years ago

Related: https://github.com/OpenOrienteering/mapper/issues/610

ollesmaps commented 4 years ago

At some point I noticed the Measurement tool had built-in under minimum sizes feature. I can not see it there any more (now 0.9.1). That was good and simple solution!

lpechacek commented 4 years ago

AFAICT, the function is still there.

However, the map symbol definitions must contain the minimum dimension numbers. For instance, if you open an .ocd file, the minimum size checking won't trigger as the fields are not filled in. Would that be an explanation to what you are seeing?

ollesmaps commented 4 years ago

I may do st wrong. I see this (Mapper 0.9.1):

min

ollesmaps commented 4 years ago

Oh I see the problem now. It is import from Ocad. So the minimum dimension is not set. Sorry for confusion. Thanks Libor!

valdisj commented 4 years ago

So what is we come back to this idea once more - for legibility of map reading, quality of drawing extremely depends on if minimum sizes, dimensions and distances are taken into account. Suggestion: to implement a setting / or a process similar to OCAD legibility setting, which, when launched, does mark all the objects, if they are not according to minimum size or distance between them and others. Anybody has good simple ideas how to show that on screen?

ollesmaps commented 4 years ago

The Measurement tool with built-in under minimum sizes feature is very good! If there is in future a possibility to: 1) minimize the pop up window - it occupies too much drawing spaces at the moment. 2) and still be able to see there is a minimum size clash (bright color inside the pop up window?)

I think then this issue would be solved.

dg0yt commented 4 years ago

@ollesmaps Did you notice that this is a dock widget which can be attached to the same region as the symbol widget? Or do you refer to the Android user interface?

lpechacek commented 4 years ago

On Android, the widget can be docked above, next to, or below the drawing area. Not sure if that helps Olles, though.

image

ollesmaps commented 3 years ago

On Android, the widget can be docked above, next to, or below the drawing area. Not sure if that helps Olles, though.

The widget is very useful! I had been using it quite extensively. The best location of the widget seems to be left down corner.

On an efficiency sidenote ;) :

  1. The widget takes up a lot of space.
  2. Most of the time the crucial info is just bellow/ over prescribed size. Or to be exact bellow is essential.
  3. Which could be perhaps minimized into an "icon sized" widget?

OR. Could this work? The sentence This object is too small is at the second half of the widget text. You have to have the widget window rather big to see it. What about moving just a piece of this info at the beginning of the widget text. I imagine three red exclamation marks or similar. This would enable to minimize the widget window and see the crucial info at the same time.

mlerjen commented 3 years ago

Or an icon itself. Grayed out if no minimal size is given to this symbol. Green if size is okay, Red if not.

X-P Maybe even adding an annoying honking sound every time the an undersized feature is drawn would save us from the upcoming 7.5K map flood X-P

Zerbembasqwibo commented 3 years ago

Possibility to include live 'distance to other stuff'-control, later on? And to start with point objects, seems easier.

But tha mappers who would need it most, will turn it off, or use other sw?

tisdag 20 juli 2021 skrev mlerjen @.***>:

Or an icon itself. Grayed out if no minimal size is given to this symbol. Green if size is okay, Red if not.

X-P Maybe even adding an annoying honking sound every time the an undersized feature is drawn would save us from the upcoming 7.5K map flood X-P

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/OpenOrienteering/mapper/issues/1021#issuecomment-883285025, or unsubscribe https://github.com/notifications/unsubscribe-auth/AD3LQD52KNLKN3I2RWJDBVTTYVGBRANCNFSM4EG7VUCA .

ollesmaps commented 1 year ago

Ocad introduced a simple "check directly during drawing whether the drawn line or area object corresponds to the minimum dimension". If ok - green. If not - red.

https://www.facebook.com/OCADInc/videos/1513724305797466 https://ocad.com/blog/2022/11/check-readability-of-orienteering-maps-directly/

I like the simplicity of it and direct and clear feedback when drawing. I assume Ocad team reads it here as well :) See suggestion in this thread:

Or it can change symbol icon background color when object is being edited - if under limit highlighted color, if ok as usuall. color_symbol

dl3sdo commented 1 year ago

What about the idea from @dg0yt of adding a special keyword to the "Find" dialog?

https://user-images.githubusercontent.com/14225666/207160561-63142965-09c1-4c4b-8b41-79d8b0c9d2bd.mp4

mlerjen commented 1 year ago

@dl3sdo Why not a tool button that does this selection (find all) inside the current window? :-)

dl3sdo commented 1 year ago

@dl3sdo Why not a tool button that does this selection (find all) inside the current window? :-)

That's also an option, in this case there will be no stepping through the findings.