OpenOrienteering / mapper

OpenOrienteering Mapper is a software for creating maps for the orienteering sport.
https://www.openorienteering.org/apps/mapper/
GNU General Public License v3.0
404 stars 108 forks source link

Map scale info in app #1040

Open ollesmaps opened 6 years ago

ollesmaps commented 6 years ago

Once a map is opened in Anroid app, there is no way how to find out map scale. I think, it should be written somewhere. You can get a file from stranger, etc. Maybe a button summarizing scale, grid, declination would do it.

On desktop the only place where to find map scale is at Change map scale? It is worth considering including it also somewere else. Georeferencing? Map notes?

dg0yt commented 6 years ago

Once upon a time the scale was in the georeferencing dialog. I wasn't happy that it was removed.

Now there is a much more "map information" which might be worth displaying, like number of object, symbols etc.

lpechacek commented 6 years ago

I tried the possibility of displaying map scale along with zoom level. It was ugly. A separate info dialog looks like a better idea to me.

krticka commented 6 years ago

@dg0yt

Once upon a time the scale was in the georeferencing dialog. I wasn't happy that it was removed.

As I remember the problem was that the field with scale value was active. Many users made mistake when they accidentally changed it. Or they were changing it intentionally thinking that they will change the scale and also symbol sizes. Than, both mistakes were causing many scale related problems to users. There is nothing against scale in georeferencing dialog, but field must be inactive.

dg0yt commented 6 years ago

There is nothing against scale in georeferencing dialog, but field must be inactive.

That's what I would have proposed: a read-only field, followed by a button ("Change...", gear, pencil, whatever).

ollesmaps commented 6 years ago

Within the app the place could be in info under measurement button.

krticka commented 6 years ago

There are few other places where it can be placed.

ghost commented 6 years ago

I tried the possibility of displaying map scale along with zoom level. It was ugly. A separate info dialog looks like a better idea to me.

Yeah, this info should be somewhere visible, also thought about that.

Within the app the place could be in info under measurement button.

Fully agreed! But I think this should be just first line on "Measure" widget. Here is draft:

pic.1

dg0yt commented 6 years ago

Within the app the place could be in info under measurement button.

Fully agreed!

I disagree. This window is for the current selection (which changes frequently). I don't think it is a good idea to fill it with static information.

ghost commented 6 years ago

This window is for the current selection (which changes frequently). I don't think it is a good idea to fill it with static information.

Well, then why not show map scale info here while there no objects selected?

pic.2

dg0yt commented 6 years ago

That sound feasible, indeed.

ghost commented 6 years ago

That sound feasible, indeed.

If so, then maybe try show not only map scale info here, but also show other map info (such as current map georeferencing info, etc.). Text color, maybe, should be not black, but grey.

pic.3

So, it would be something like "map dashboard" (while "No object selected.")

lpechacek commented 6 years ago

FWIW, a new "map info" dialog looks like a the best way to go.

Please note that this issue report started as a request for the mobile UI enhancement. The desktop UI part has been mixed into it along the way.

The mobile UI does not have any georeferencing or map notes dialog. Therefore the map scale info information will have to be presented in a separate dialog or a "toast" and a separate button to trigger the action has to be added. For the desktop UI the same action can be triggered from menu.

I'm not a big fan of adding the information bits into Measure dialog as it looks like a workaround to current mobile UI deficiencies.

A prototype implementation is referenced above.

image

ghost commented 6 years ago

Therefore the map scale info information will have to be presented in a separate dialog or a "toast" and a separate button to trigger the action has to be added. For the desktop UI the same action can be triggered from menu.

Nice implementation, but it's look like add menu entry/icon on toolbar for one more widget/info message is little bit not good idea.

For Desktop UI main idea (that sketched by me above) is to re-use "Measure" widget empty space while there no object selected.

For Mobile UI additional "Map info" icon on toolbar & notification message window is OK.

UPD: It would be better if such info message will shown when double-tap on "- Map -" item on "Templates" widget. So, no need add new menu entry/icon on toolbar in Mobile & Desktop UI

pic.3

krticka commented 6 years ago

Double-tap on Map item in templates seems to be elegant solution but it will be quite hidden solution for many users. What about to add small info icon to Map item?

clipboard01

lpechacek commented 6 years ago

@Symbian9, @krticka, your (intuitive) observation that there is no space left on the main screen is completely correct. However, instead of attempting to make more space on the main screen, you are trying to find a "small change" which has so far led to compromises. I'm pretty sure you feel that few people would would look for that map scale information under Template setup or Measure object.

My proposal is to place Map info function in the vicinity of Show whole map and Show grid functions in the top left corner. Room for it could be created by hiding less frequently used functions under a single icon. My impression is that at least four of the eight icons in the top left corner are rarely used during a surveying session. They are Compass display toggle, Location display toggle, Show whole map and Grid display. I propose hiding these functions under a new icon, just like the direct skip to 1x and 2x zoom are hidden under Zoom out, and adding Map info into that group.

How does that sound to you?

image (Of course, the icon for "Extras" has to be invented. :) )

krticka commented 6 years ago

That sounds perfect to me. You can put there also Automatic north alignment (personally I am not using this option) and distance rings (I select this option only once when I open the file and start mapping). Then there will be more space for the other editing functions on smaller screens.

krticka commented 6 years ago

Relates to #865

ollesmaps commented 6 years ago

@lpechacek I agree, it should have a separate button.

However I would like to keep Show whole map visible as I use it quite often (need to get an overview what had been done and needs to be done). I would not mind though if Show whole map gets moved in the down left corner, where zooming occurs. It very much relates - after maxi zoom out you have to zoom in. As suggested in #952.

Could the Map Info also contain map statistics as suggested in #1097?

ghost commented 6 years ago

What about to add small info icon to Map item?

Seems like good solution too. Just move "Info" icon/button to the bottom of "Templates" widget:

pic.1

  1. Tap on on template entry (- Map - or other template);
  2. Tap on "Info" icon/button;
  3. Show "Info" message.
krticka commented 6 years ago

That is also solution but @lpechacek solution seems to me better as it fixes problems with accessibility of some editing functions on smaller screens. For example I am mapping on Samsung Galaxy Note 4 and half of the icons I use frequently are hidden in drop down menu now.

screenshot_2018-11-02-10-20-59

ghost commented 6 years ago

Could the Map Info also contain map statistics

+1. This is what I mean under "map dashboard" inside "Measure" widget (in my comment above)

lpechacek commented 6 years ago

Thanks for the responses. I'll look into further implementation, taking your feedback into account, soon.

Relates to #865

Yes. I can't but agree with Medvěd on his observations. That is what I call "mobile UI deficiencies" in one of my previous comments.

(Krtek) You can put there also Automatic north alignment (personally I am not using this option)... ... (Olles) However I would like to keep Show whole map visible as I use it quite often...

I've already looked into implementation of configurable mobile UI but I wasn't satisfied with the direction it was developing. I plan to return to it and also include Martin Lerjen's proposal. But don't hold your breath for the new UI. It will take me some time to get it done and then dg0yt will request changes. Or if someone else adopts this task, it may happen earlier.

For now, if we put three least used functions under one icon, we can call it progress.

Could the Map Info also contain map statistics...

Yes, I'm aware of the request and I agree that Map info dialog would be a good place where to present the results.