search

OpenOrienteering / mapper

OpenOrienteering Mapper is a software for creating maps for the orienteering sport.
https://www.openorienteering.org/apps/mapper/
GNU General Public License v3.0
402 stars 106 forks source link

Function of "Fill bounded areas" - bug or feature? #1589

Open stefankinell opened 4 years ago

stefankinell commented 4 years ago

Steps to reproduce

  1. start with one bounded area within another - see image with box and square
  2. use tool "fill bounded areas" and click outside the circle
  3. observe as the whole square gets filled, not only the outer area

Actual behaviour

That the outer area would be filled, but inner would remain unfilled - since logically the paint would not flow through the inner border.

Expected behaviour

I expected only the outer area - that are connected, to be filled. This is how this tool has always worked e.g. i Photoshop and other image editing tools.

Configuration

Mapper Version: 0.92 Operating System: Windows 10 oom-kanter oom-kanter-fyllt

dg0yt commented 4 years ago

I don't think creating holes inside the new object is currently supported. We are successful in finding the single outer boundary, but generally finding all holes will be require more thorough (slow) search.

stefankinell commented 4 years ago

OK, then I understand how the feature is built. It's a great support especially when drawing sprint maps, but if it only tracks outer boundaries I have to do workarounds and temporary close off inner boundaries with some lines. Works OK but a bit time consuming in larger areas, on the other hand - less time consuming than tracing borders for every area that are to be filled, e.g. hard surfaces or areas not to pass.

thanks for quick feedback!

mlerjen commented 4 years ago

Simplest way would likely be to use the cut-away function to cut the circle "island" away from the square "sea"-area.

stefankinell commented 3 years ago

How do I turn this question into a feature request? I.e. making the fill feature only fill the areas that actually are connected to the place where I click, not the inner areas like the example above. I once again found myself in a situation where I get a lot of help with the fill feature, but it takes me one hour instead of five minutes, to draw roads inside an area with houses, grass fields etc

dg0yt commented 3 years ago

How do I turn this question into a feature request?

I do regard it as a feature request anyway. The question is how this feature request can be turned into a feature...