Cut control circles are imported as full circles (.ocd)

lpechacek commented 2 years ago

Steps to reproduce

Set a course in OCAD, cut circles for better detail visibility
Export a course map to .ocd
Open the map in Mapper

Actual behaviour

Circles that were cut come up as full circles again, without any import warning.

Expected behaviour

Either circles should be cut, or there should be a warning about an unsupported feature.

Discussion

Merely for the record here. This is not a hint that we should implement circle cutting.

Control point circle cutting is an undocumented feature in the .ocd format documentation. However, it turns out that there might be more than one record in the Poly array of the TOcadObject structure. The first coordinate is the point object placement. The second and following records are the circle cut angles as pairs of 32-bit signed integers in the case of cut circles. The pairs encode the cut start angle and end angle in tenths of degrees. The angles are in the range <-180.0; 180.0> degrees with zero on the right and positive angles going counter-clockwise. Mind that these angles are combined with the whole point object rotation (the TOcadObject.Ang value).

These cuts apply to all (hollow) circles in the symbol regardless of their position within the point symbol definition itself.