search

OpenOrienteering / mapper

OpenOrienteering Mapper is a software for creating maps for the orienteering sport.
https://www.openorienteering.org/apps/mapper/
GNU General Public License v3.0
399 stars 106 forks source link

MeasureWidget: Show warning icon for small objects #2252

Closed lpechacek closed 3 months ago

lpechacek commented 3 months ago

This change enhances visibility of the small object warning in the measure tool. The use case is to shrink the measure tool window to a minimum size so that only the top line is visible and keep it in the view field during drawing. New sub-size object will trigger the colored warning icon, giving the user opportunity to fix the legibility issue on the go.

Idea contributed by @ollesmaps.

Screenshot from 2024-06-28 01-10-21

dl3sdo commented 3 months ago

@lpechacek: thank you Libor for this PR. I successfully tested it: MeasureWarningIcon

lpechacek commented 3 months ago

Please add #include <QString> to .h file since you added QString warning_icon;

Done.

Proposal: in .h file change to Copyright 2015, 2024 Kai Pastor and add Copyright 2024 Libor Pecháček to .cpp file

Updated the line with Kai's name as it's now common in OO. I'm not adding my own line for such a triviality though. Although the usability impact of the change is high, the coding effort is not worth a mention.

dg0yt commented 3 months ago

Thanks.