search

OpenOrienteering / mapper

OpenOrienteering Mapper is a software for creating maps for the orienteering sport.
https://www.openorienteering.org/apps/mapper/
GNU General Public License v3.0
399 stars 106 forks source link

CI: Migrate from PCCR@V1 to ReportGenerator #2262

Closed dl3sdo closed 2 months ago

dl3sdo commented 2 months ago

Although the current V1 version of the publish code coverage results task is still available it's recommended to stop using the V1 version and migrate to V2 version.

dl3sdo commented 2 months ago

There seems to be a dispute about migrating to V2: New version of Publish Code Coverage Results task See also: https://github.com/danielpalme/ReportGenerator/wiki/Integration

dg0yt commented 2 months ago

So V2 doesn't offer click-through to the sources. Do really want to upgrade? Does https://github.com/danielpalme/ReportGenerator/issues/646#issuecomment-2110990308 provide an alternative?

dl3sdo commented 2 months ago

As there is currently nothing that forces us to move to V2 let's give the alternative solution a try, otherwise let's continue with V1. @dg0yt: do you have to install the ReportGenerator extension from the Marketplace first?

dl3sdo commented 2 months ago

/azp run

azure-pipelines[bot] commented 2 months ago
Azure Pipelines failed to run 1 pipeline(s).
dg0yt commented 2 months ago

I added the ReportGenerator from the AZP marketplace. I couldn't re-run the failed job, but I could start a new run for the same merge commit.

dg0yt commented 2 months ago

Seems to work now. Before: https://dev.azure.com/OpenOrienteering/Mapper/_build/results?buildId=2903&view=codecoverage-tab After: https://dev.azure.com/OpenOrienteering/Mapper/_build/results?buildId=2907&view=codecoverage-tab

dl3sdo commented 2 months ago

Seems to work now. Before: https://dev.azure.com/OpenOrienteering/Mapper/_build/results?buildId=2903&view=codecoverage-tab After: https://dev.azure.com/OpenOrienteering/Mapper/_build/results?buildId=2907&view=codecoverage-tab

For me it looks rather that one report is V1 and one report is V2 but none of them is Daniel Palme's report.

dg0yt commented 2 months ago

AFAIU V1 uses an old version of that ReportGenerator, so similarities are expected. And you can check the steps run for the coverage pipeline.

In fact, the version is reported in the footer. Before: ReportGenerator 5.2.2.0 After: ReportGenerator 5.3.8.0

dg0yt commented 2 months ago

FTR V2 is https://dev.azure.com/OpenOrienteering/Mapper/_build/results?buildId=2897&view=codecoverage-tab.

dg0yt commented 2 months ago

Close/Re-open to reset state.

dg0yt commented 2 months ago

Thanks.

dg0yt commented 2 months ago

This PR was meant to be squashed when merged... I will force-push master. CC @dl3sdo @lpechacek.