search

OpenOrienteering / mapper

OpenOrienteering Mapper is a software for creating maps for the orienteering sport.
https://www.openorienteering.org/apps/mapper/
GNU General Public License v3.0
404 stars 108 forks source link

Fix compiler warnings #2264

Closed dg0yt closed 3 months ago

dl3sdo commented 3 months ago

Another observation for various fixes: In kml_course_export.h the #ifndef OPENORIENTEERING_KML_EXPORT_EXPORT_H should rather be #ifndef OPENORIENTEERING_KML_COURSE_EXPORT_H

dg0yt commented 3 months ago

Is file_format_registry.cpp missing?

It is unclear if this is intentional... As mentioned before, we should have an exclusion list instead.

kml_course_export, iof_course_export should rather have a .cpp

It is a simple pattern match. No .cpp required. In fact some patterns are intentionally short. We could have course_export. Or we could have fileformats/.

dl3sdo commented 3 months ago

Another observation for various fixes: In kml_course_export.h the #ifndef OPENORIENTEERING_KML_EXPORT_EXPORT_H should rather be #ifndef OPENORIENTEERING_KML_COURSE_EXPORT_H

Addressed by #2265