OpenOrienteering / mapper

OpenOrienteering Mapper is a software for creating maps for the orienteering sport.
https://www.openorienteering.org/apps/mapper/
GNU General Public License v3.0
396 stars 106 forks source link

Correct black for some symbols in ISMTBOM symbol sets #789

Open ghost opened 7 years ago

ghost commented 7 years ago

Steps to reproduce

Try make cross using 501 (or 502, or 503) and some of 831 - 838 line symbols

Actual behaviour

Currently 831 - 838 symbols placed over 501 - 503, because they use "Black" color

Expected behaviour

501 - 503 symbos must be above 831 - 838. According this 831 - 838 symbols must use "Black bellow light browns"

Configuration

Mapper Version: 0.6.6 Operating System: Linux, 64bit

REFERENCES

ghost commented 7 years ago

Also, symbol number "501.0" must be renamed to "501" according ISMTBOM specification.

dg0yt commented 7 years ago

The numbers and colors of our implementation of ISMTBOM are chosen to match those of our implementation of ISOM. This makes it easy to replace the symbol sets.

ghost commented 7 years ago

our implementation of ISMTBOM

OOMapper firstly must use official specification number.

Replacing symbols is user related task, not a program task. User must know how do it. Replacing is not a task of OOMapper.

dg0yt commented 7 years ago

Replacing symbols is an operation users want (and deserve) software support for, especially when converting a map from ISOM to ISMTBOM.

I leave this open for commenting by others.

ghost commented 6 years ago

Replacing symbols is an operation users want (and deserve) software support for, especially when converting a map from ISOM to ISMTBOM.

Since Mapper v0.8.x has CRT rules for symbols replacement, maybe need review this issue?

dg0yt commented 6 years ago

There is only one sub-issue supported by CRT file support: Mapping between 501 and 501.0. (And of course mapping roads and paths by tags to ISMTBOM tracks.) It doesn't change anything about the colors: our ISOM2000 504 Road uses Black (above Brown), and so does our ISMTBOM 831 Track: fast riding.