search

OpenPDroid / OpenPDroidPatches

Framework patches for OpenPDroid permission management
GNU General Public License v3.0
38 stars 24 forks source link

next release #2

Closed mateor closed 11 years ago

mateor commented 11 years ago

I am not sure what is on your action list, but I think we should discuss releasing again. The auto-patcher leads me to believe that our current master branch has merge (and therefore build patch) conflicts with three or four classes (GSMServicestateTracker, CDMA ServiceStateTrack, SMSDispatcher and maybe Phone Factory).

I have hot fixes in the form of provisional files (which are simply copies of those smali files as they were when we made the patches. Essentially we have just rolled the offending commits back.) But we should build again. ICS and 4.1 were like this, breaking constantly, that is why the ROM probe getting rid of the patch date argument was such a help.

Since we are producing new builds, I think we may as well release the fixes you have done. I don't known what you have left, probably the SMS bugs. But that COULD be due to the SMSDispatcher merge conflict and might be fixed by rebuilding.

Let me know.

mateor commented 11 years ago

I saw you pushed some things to cm-10-openpdroid. But I will need to push stuff to aosp (jb-mr1-openpdroid) in order to update the build patches. I will do that tonight so I can start building over here but I will only pull the stuff we spoke about.

mateor commented 11 years ago

Smali patches are looking to be behind some FCs. Looks like one of the files had a commit being called elsewhere. I am going to make new patches tonight by pushing over the fixes we talked about.

CollegeDev commented 11 years ago

When I'm back at home I can send you the new telephony registry, which is completely rewritten and do not need to port in future. Hopefully I will have some spare time....

mateor commented 11 years ago

Sure, looking forward to it. It has been great having you be involved with this...we're looking into starting up a Gerrit instance, so we can have an official framework to evaluate and discuss tricky code/philosophic differences. But having all of us working on this together...the platform is going to benefit.

mateor commented 11 years ago

Okay, I am officially going to wait until i talk to you, which hopefully won't be too long. I just am not 100% clear on the demarcation of what you intend to be pushed to release and what should remain in devel. I have been meaning to just cherry-pick and merge it over, but since this will become our defacto new release, I don't want to be hasty, especially because without help with the building process, it will take me several days to put together the new patches anyway.

But if you have a list of the framework commits you are comfortable releasing, let me know. As of now, I am assuming everything in Mms, Libcore, Build (if anything) and then the commits that are related to existing bugs and cache in the telephony and base. If you are still moving, I will revisit on Sunday night.

mateor commented 11 years ago

AOKP failing now. I guess I will just make some educated guesses. My time is limited, but I may try and just push this over tonight. If not then, monday.

wsot commented 11 years ago

Sorry all - I still have no home connection, and am still under the pump at work so haven't been able to capitalise on theirs.