search

OpenPDroid / platform_frameworks_base

Other
7 stars 5 forks source link

PrivacyManagerService change #5

Open mateor opened 11 years ago

mateor commented 11 years ago

The move to 'final' in the smali broke the recompile of the framework.jar with this message

 tmp/system/framework/framework.jar.out/smali/android/privacy/PrivacySettingsManagerService.smali[0,-1] mismatched input '<EOF>' expecting END_METHOD_DIRECTIVE

I reverted the commit here: https://github.com/mateor/auto-patcher/commit/1fd613e2b21c3ee430c755760a520e72697abad1

You can close this issue whenever you read this as it has been rectified (although I guess the original bug is back in the PDroid code. Up to you if you want to play with it.)

wsot commented 11 years ago

Yeah, we're going to have to put that 'final' through at some point - otherwise it is possible to override the PrimacySettingsManagerService in the PrivacySettingsManager object, and that can be used to force 'allow' responses.