OpenPEPPOL / logistics-bis

3 stars 0 forks source link

Both Country identification code and country name #25

Closed DidrikN closed 1 year ago

DidrikN commented 1 year ago

There are currently both country IdentificationCode and country name on several elements in Transport Execution Plan Request. In advanced despatch advice we only had "IdentificationCode", so I'm guessing this is sufficient also for Transport Execution Plan Request?

I have found these instances of this: cac:Consignment / cac:PreCarriageShipmentStage / cac:CarrierParty / cac:PostalAddress / cac:Country cac:Consignment / cac:ConsignorParty / cac:PostalAddress / cac:Country cac:Consignment / cac:FreightForwarderParty / cac:PostalAddress / cac:Country

My suggestion is to remove "Name" from these Country-elements.

DidrikN commented 1 year ago

@PeterLBorresen: Any comments on this? Did you make it like tis on purpose or can we remove the "Name"-elements from Country?

PeterLBorresen commented 1 year ago

I will allign this to the other Peppol specifications

DidrikN commented 1 year ago

@PeterLBorresen: Please remove "Country name" from all instances as Country identification code is sufficient, as agreed in the WG-meeting Monday February 27th.

PeterLBorresen commented 1 year ago

Done

agrindst commented 1 year ago

Name is removed in: cac:Consignment / cac:PreCarriageShipmentStage / cac:CarrierParty / cac:PostalAddress / cac:Country cac:Consignment / cac:ConsignorParty / cac:PostalAddress / cac:Country

Considering: cac:Consignment / cac:FreightForwarderParty / cac:PostalAddress / cac:Country Issue 48 reffering to issue 48 , FreightForwarderParty is removed.