OpenPEPPOL / logistics-bis

3 stars 0 forks source link

Consider cardinallity of Delivery location/ ID #61

Closed PeterLBorresen closed 1 year ago

PeterLBorresen commented 1 year ago

In case the delivery location is using an address, why do we then need to specify the delivery location id. Maybe we need a business rule for this?

agrindst commented 1 year ago

Peter is suggesting to change Delivery location to not mandatory.

suggestion: make a business rule that about specifying address or Location ID

JorgenErlandsson commented 1 year ago

I agree that the ID must be changed to optional. Sometimes the DeliveryLocation is just some gps coordinates and we must allow that. Since the location can be more or less anything I do not see that we need any rule to check it.

Suggest to change cardinality to 0..1 only.

agrindst commented 1 year ago

Please complete this issue

Actions:

JorgenErlandsson commented 1 year ago

This issue is now fixed and can be closed.