search

OpenPF2 / Plugin

Core C++ Game Logic for OpenPF2 (Status: Pre-alpha)
https://www.openpf2.org/
Other
23 stars 6 forks source link

Switch to Enhanced Specs Plug-in #64

Closed GuyPaddock closed 1 month ago

GuyPaddock commented 1 month ago

The Enhanced Specs plug-in is only available in uncooked builds. Given this, tests from OpenPF2 had to be moved into a separate module that only loads in uncooked builds as well.

While here, I switched the project back to using automatic PCH files and ensured that all files had the OpenPF2 include file when necessary.

Closes #62.

coderabbitai[bot] commented 1 month ago

Walkthrough

This update includes the introduction of two new modules, "OpenPF2Tests" and "EnhancedAutomationSpecs," and various dependency reconfigurations. Specific changes involve multiple file updates where "OpenPF2Core.h" is added for necessary includes. Additionally, alterations in build configurations and dependency assignments streamline the project. Numerous files have been modified to include this header, simplifying and centralizing the core relationships.

Changes

Files Change Summary
OpenPF2Core.uplugin, Source/OpenPF2BlueprintNodes/...Build.cs, Source/OpenPF2Core/...Build.cs New modules introduced, updated loading phases, reordering and addition of dependencies.
Source/OpenPF2Core/Private/Abilities/..., Source/OpenPF2Core/Private/Actors/... Added #include "OpenPF2Core.h" in multiple files to centralize core dependencies.
Source/OpenPF2Core/Public/CharacterStats/... Modified file inheritance by adding OPENPF2CORE_API macro.
Source/OpenPF2Core/Private/PF2... Reordered and simplified include directives.
Source/OpenPF2Core/Private/...Component.cpp Multiple components updated include statements, minor fixes, year updates, header rearrangements.
.../Public/PF2GameModeBase.h Removed #include <GameFramework/GameStateBase.h>, affecting dependencies and code organization.

Sequence Diagram(s)

No significant new features or major control flow modifications are introduced, so sequence diagrams are not provided.

Assessment against Linked Issues

Objective (Issue) Addressed Explanation
Apply fixes from EnhancedUnrealSpecs (62) ✅

Poem

Amid our code, new modules sprout, Dependencies sorted, no more doubt. Headers gathered, unified core, OpenPF shines, like never before. 🎉🐇💻

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share - [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)
Tips ### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit .` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai generate interesting stats about this repository and render them as a table.` - `@coderabbitai show all the console.log statements in this repository.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` - `@coderabbitai help me debug CodeRabbit configuration file.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (invoked as PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger an incremental review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai full review` to do a full review from scratch and review all the files again. - `@coderabbitai summary` to regenerate the summary of the PR. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai configuration` to show the current CodeRabbit configuration for the repository. - `@coderabbitai help` to get help. Additionally, you can add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. ### CodeRabbit Configration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - Please see the [configuration documentation](https://docs.coderabbit.ai/guides/configure-coderabbit) for more information. - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json` ### Documentation and Community - Visit our [Documentation](https://coderabbit.ai/docs) for detailed information on how to use CodeRabbit. - Join our [Discord Community](https://discord.com/invite/GsXnASn26c) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.
GuyPaddock commented 1 month ago

@coderabbitai review

coderabbitai[bot] commented 1 month ago
Actions performed Review triggered. > Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.
GuyPaddock commented 1 month ago

NOTE: Due to a rebase on the target branch, this PR was merged as b095fa24e245bdade450466e4dc891268e88adaa instead of 8847483c86df57e9dc2ea4ad1a398a1d450257f3.