OpenPHDGuiding / phd2

PHD2 Guiding
https://openphdguiding.org
BSD 3-Clause "New" or "Revised" License
255 stars 115 forks source link

Add indi rotator support #1041

Open mgutierrezp opened 1 year ago

mgutierrezp commented 1 year ago

Hi,

I would please request indi rotators support for phd2 (linux version, obviously). Currently it seems is not supported. I have an electronic rotator (falcon) before my oag. Any rotation forces me to recalibrate. This is a major problem since I'm running an automated setup during the night and imaging multiple objects with different rotation.

Regards

mgutierrezp commented 1 year ago

dear developers; it's not my intention to push you, honestly. I would only like to know if it is feasible to implement this feature, just to know and plan to switch to ascom :(

bwdev01 commented 1 year ago

I would say it’s definitely feasible but it will take some work by a Linux developer who is conversant with Indi. So I don’t think it’s likely to happen very soon unless you get lucky. In the meantime, you could try to reduce the number of times you move the rotator - rotation isn’t needed for guide star selection or meridian flips.

Regards,

Bruce

From: mgutierrezp @.> Sent: Tuesday, March 7, 2023 12:43 AM To: OpenPHDGuiding/phd2 @.> Cc: Subscribed @.***> Subject: Re: [OpenPHDGuiding/phd2] Add indi rotator support (Issue #1041)

dear developers; it's not my intention to push you, honestly. I would only like to know if it is feasible to implement this feature, just to know and plan to switch to ascom :(

— Reply to this email directly, view it on GitHub https://github.com/OpenPHDGuiding/phd2/issues/1041#issuecomment-1457770337 , or unsubscribe https://github.com/notifications/unsubscribe-auth/ADDHSVYXNZ3XUEDW5XXS6W3W23YIVANCNFSM6AAAAAAVL4AKQY . You are receiving this because you are subscribed to this thread. https://github.com/notifications/beacon/ADDHSV4ZUBNNZ2TB2YVUSVDW23YIVA5CNFSM6AAAAAAVL4AKQ2WGG33NNVSW45C7OR4XAZNMJFZXG5LFINXW23LFNZ2KUY3PNVWWK3TUL5UWJTSW4PHWC.gif Message ID: @. @.> >

mgutierrezp commented 1 year ago

Thanks for the reply, Bruce.

On a single and complete night, I usually shoot more than one object. The number and the objects depends of the seasons. The number of rotations depends on the objects. You see my point I guess. Very often is unavoidable to rotate the camera to get the proper framing (not for meridian flips and pick a guiding star, as you correctly state). So in my situation is not strange I need to rotate at least once to take the most of the new rotator . The only feasible workaround I've found is to tell to ekos to force calibration on each slew, which is possible. You can imagine the drawbacks.

Hope you get this feature implemented. In the meanwhile, I'm exploring the ascom world, or recalibrate every time the mount slews.

Regards

El mar, 7 mar 2023, 18:20, bwdev01 @.***> escribió:

I would say it’s definitely feasible but it will take some work by a Linux developer who is conversant with Indi. So I don’t think it’s likely to happen very soon unless you get lucky. In the meantime, you could try to reduce the number of times you move the rotator - rotation isn’t needed for guide star selection or meridian flips.

Regards,

Bruce

From: mgutierrezp @.> Sent: Tuesday, March 7, 2023 12:43 AM To: OpenPHDGuiding/phd2 @.> Cc: Subscribed @.***> Subject: Re: [OpenPHDGuiding/phd2] Add indi rotator support (Issue #1041)

dear developers; it's not my intention to push you, honestly. I would only like to know if it is feasible to implement this feature, just to know and plan to switch to ascom :(

— Reply to this email directly, view it on GitHub < https://github.com/OpenPHDGuiding/phd2/issues/1041#issuecomment-1457770337> , or unsubscribe < https://github.com/notifications/unsubscribe-auth/ADDHSVYXNZ3XUEDW5XXS6W3W23YIVANCNFSM6AAAAAAVL4AKQY> . You are receiving this because you are subscribed to this thread. < https://github.com/notifications/beacon/ADDHSV4ZUBNNZ2TB2YVUSVDW23YIVA5CNFSM6AAAAAAVL4AKQ2WGG33NNVSW45C7OR4XAZNMJFZXG5LFINXW23LFNZ2KUY3PNVWWK3TUL5UWJTSW4PHWC.gif> Message ID: @. @.> >

— Reply to this email directly, view it on GitHub https://github.com/OpenPHDGuiding/phd2/issues/1041#issuecomment-1458546410, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABDWGUM5QONLGWAVQKX6L5TW25U6DANCNFSM6AAAAAAVL4AKQY . You are receiving this because you authored the thread.Message ID: @.***>

pchev commented 1 year ago

I just take a quick look at the existing rotator code and INDI rotator simulator properties and I think this is possible to add to PHD2. The equivalent of ASCOM Position is ABS_ROTATOR_ANGLE.ANGLE. But unfortunately I not have the time to work on that right now.

d33psky commented 1 year ago

I'm in the same boat as Patrick. One of the INDI drivers I wrote was a rotator+focuser and I've contributed some Linux code to PHD2 but I have just no time to work on your request right now.

mgutierrezp commented 1 year ago

Thanks to all of you guys for looking into this. I fully understand you are time-limited and working selflessly in this project. All phd2 users thank you for your job and effort.

best

El mar, 7 mar 2023 a las 22:30, d33psky @.***>) escribió:

I'm in the same boat as Patrick. One of the INDI drivers I wrote was a rotator+focuser and I've contributed some Linux code to PHD2 but I have just no time to work on your request right now.

— Reply to this email directly, view it on GitHub https://github.com/OpenPHDGuiding/phd2/issues/1041#issuecomment-1458900753, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABDWGUIPPHJIIOGD2DZDHB3W26SHDANCNFSM6AAAAAAVL4AKQY . You are receiving this because you authored the thread.Message ID: @.***>

mgutierrezp commented 1 year ago

Dear developers,

I was just wondering if you have had any chance to get into this. Really appreciate your effort.

Regards

El jue, 9 mar 2023 a las 8:46, Miguel Gutiérrez Páez @.***>) escribió:

Thanks to all of you guys for looking into this. I fully understand you are time-limited and working selflessly in this project. All phd2 users thank you for your job and effort.

best

El mar, 7 mar 2023 a las 22:30, d33psky @.***>) escribió:

I'm in the same boat as Patrick. One of the INDI drivers I wrote was a rotator+focuser and I've contributed some Linux code to PHD2 but I have just no time to work on your request right now.

— Reply to this email directly, view it on GitHub https://github.com/OpenPHDGuiding/phd2/issues/1041#issuecomment-1458900753, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABDWGUIPPHJIIOGD2DZDHB3W26SHDANCNFSM6AAAAAAVL4AKQY . You are receiving this because you authored the thread.Message ID: @.***>

comptonizing commented 1 year ago

I will be facing the same situation soon, so I added the rotator support, see #1091 .

mgutierrezp commented 1 year ago

Philipp, you made my day mate. I've just compiled your branch and works flawlessly. Guiding is horrible cause it's very windy here, but the rotator is recognized perfectly and the guiding still works and corrections seem consistent after some rotations. I'm very grateful for this implementation. Thanks a lot. Really appreciate it.

Regards

El sáb, 26 ago 2023 a las 18:35, comptonizing @.***>) escribió:

I will be facing the same situation soon, so I added the rotator support, see #1091 https://github.com/OpenPHDGuiding/phd2/pull/1091 .

— Reply to this email directly, view it on GitHub https://github.com/OpenPHDGuiding/phd2/issues/1041#issuecomment-1694405572, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABDWGUK45DCBZAFJFJUXWYTXXIQVFANCNFSM6AAAAAAVL4AKQY . You are receiving this because you authored the thread.Message ID: @.***>

comptonizing commented 1 year ago

No worries, very happy to have done something useful in return, after many years of just using the software. Also, thanksa lot for testing it in a real scenario, I only had the simulators available.