fix cmake error on Windows

OpenPHDGuiding / phd2

PHD2 Guiding

https://openphdguiding.org

BSD 3-Clause "New" or "Revised" License

249 stars 114 forks source link

fix cmake error on Windows #1145

Closed agalasso closed 9 months ago

agalasso commented 9 months ago

The commit for #1144 bumped the cmake minimum version to 3.24 since we now use the FetchContent module. This had a side-effect of changing policy CMP0126 https://cmake.org/cmake/help/latest/policy/CMP0126.html which caused the wxWidgets find_package call to fail as the wxWidgets_CONFIGURATION variable was being set as a normal (non-cache) valriable.

agalasso commented 9 months ago

I'm going to merge this without review as without this fix Windows builds are broken. @bwdev01 if you have any requested changes I can do a followup pr.

bwdev01 commented 9 months ago

Looks good, thanks.