Closed agalasso closed 5 months ago
agalasso
commented
5 months ago should the capability be exposed for cameras that don't do hardware binning
good point. this could be used by cameras that do not do hardware binning -- we can do that as separate prs. Let me know if you had any specific cameras in mind and we can add it.
bwdev01
commented
5 months ago It was just a general notion, not specific to a particular camera. I thought we had an outstanding feature request from way back for this but maybe I’m mistaken. Having not spent much time thinking about it, perhaps we would offer the software binning option in the UI for any camera that reports a max-binning value of zero. With big CMOS sensors on guide cameras, this could be a useful way to reduce image sizes and download times. But not anything that should affect this PR.
From: Andy Galasso @.> Sent: Friday, April 19, 2024 5:51 PM To: OpenPHDGuiding/phd2 @.> Cc: bwdev01 @.>; Review requested @.> Subject: Re: [OpenPHDGuiding/phd2] minor refactor for code reuse (PR #1192)
should the capability be exposed for cameras that don't do hardware binning
good point. this could be used by cameras that do not do hardware binning -- we can do that as separate prs. Let me know if you had any specific cameras in mind and we can add it.
— Reply to this email directly, view it on GitHub https://github.com/OpenPHDGuiding/phd2/pull/1192#issuecomment-2067456640 , or unsubscribe https://github.com/notifications/unsubscribe-auth/ADDHSV3JKDFNZS5LGOU5NE3Y6G3WPAVCNFSM6AAAAABGMIUKNSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDANRXGQ2TMNRUGA . You are receiving this because your review was requested. https://github.com/notifications/beacon/ADDHSV5PEBXXYYSVRFUU25TY6G3WPA5CNFSM6AAAAABGMIUKNSWGG33NNVSW45C7OR4XAZNMJFZXG5LFINXW23LFNZ2KUY3PNVWWK3TUL5UWJTT3HLRIA.gif Message ID: @. @.> >
move some binning methods out of cam_touptek.cpp into image_math.h so the methods can be used by another camera in a forthcoming PR
no functional changes