search

OpenPHDGuiding / phd2

PHD2 Guiding
https://openphdguiding.org
BSD 3-Clause "New" or "Revised" License
244 stars 111 forks source link

Added armv8 (64bit) qhyccd sdk library #1210

Closed ceterumnet closed 5 days ago

ceterumnet commented 3 weeks ago

Adds QHYCCD SDK library for armv8 for Linux

agalasso commented 3 weeks ago

@ceterumnet was the alpaca commit to this pr unintentional?

ceterumnet commented 2 weeks ago

Yes - that was unintentional. I am super confused how that was added to this PR...I will create a new PR with only the intended changes.

ceterumnet commented 2 weeks ago

@agalasso - ok - should be good now.

ceterumnet commented 2 weeks ago

@agalasso - let me know if you need anything else from me on this.

agalasso commented 1 week ago

@ceterumnet thanks for the PR. What SDK version did the armv8 library come from? I'd like to validate that the armv8 library is the same version as the other architectures and that it is the exact same binary distributed by QHY. Also, we'll need to update the script (build/unpack_qhy_sdk.sh) that we use to unpack the QHY SDK libraries so that the armv8 library gets updated along with the others whenever we update the QHY SDK -- I can make the change to the unpack script as a separate pr once I get the info.

agalasso commented 1 week ago

@ceterumnet I put up #1215 which updates PHD2 to use the latest QHY SDK, but also happens to update the build scripts and QHY SDK unpack script to include the arm64 SDK lib. Could you please check to see if #1215's branch addresses your issue and allows PHD2 to work with your QHY camera on your armv8 system?

ceterumnet commented 5 days ago

@agalasso - I think it should work. I have tested it, but there may need to be a small tweak in order for it to build. I'll issue another PR once I've figured that out.

ceterumnet commented 4 days ago

@agalasso - FYI - I had no issues building and my camera works now on the Raspberry Pi 5. Just in case anyone ever stumbles across this and used my code...make sure you purge your CMake build directory to avoid any stale values from what I had done.