search

OpenPHDGuiding / phd2

PHD2 Guiding
https://openphdguiding.org
BSD 3-Clause "New" or "Revised" License
255 stars 115 forks source link

Want bit mode selection for QHY cameras (#1245) #1246

Closed daleghent closed 1 month ago

daleghent commented 1 month ago

Per #1245 , this enhances the QHY native driver by:

bwdev01 commented 1 month ago

Hi Dale. Did you intend to bail out on this change? I wanted to look at your PR this morning and there’s nothing to see, your branch was deleted. Did you change your mind about something?

Bruce

From: Dale Ghent @. Sent: Wednesday, October 9, 2024 9:53 PM To: OpenPHDGuiding/phd2 @.> Cc: Subscribed @.***> Subject: Re: [OpenPHDGuiding/phd2] Want bit mode selection for QHY cameras (#1245) (PR #1246)

Closed #1246 https://github.com/OpenPHDGuiding/phd2/pull/1246 .

— Reply to this email directly, view it on GitHub https://github.com/OpenPHDGuiding/phd2/pull/1246#event-14583425191 , or unsubscribe https://github.com/notifications/unsubscribe-auth/ADDHSV6VU6O5K3AXXWSP5CLZ2YBZRAVCNFSM6AAAAABPV45CRCVHI2DSMVQWIX3LMV45UABCJFZXG5LFIV3GK3TUJZXXI2LGNFRWC5DJN5XDWMJUGU4DGNBSGUYTSMI . You are receiving this because you are subscribed to this thread. https://github.com/notifications/beacon/ADDHSV6SWKL5GSPH3LNBZZ3Z2YBZRA5CNFSM6AAAAABPV45CRCWGG33NNVSW45C7OR4XAZNWJFZXG5LFIV3GK3TUJZXXI2LGNFRWC5DJN5XKUY3PNVWWK3TUL5UWJTYAAAAAGZJ5NCTQ.gif Message ID: @. @.> >

daleghent commented 1 month ago

Hi Bruce, I was testing some additional QHY models I had on hand and realized that fixing this issue may be more fraught than first realized. It's possible we may be looking at an unavoidable breaking change for some but perhaps not all QHY native driver users here. I am testing with a QHY5III462C and QHY183M currently. I feel that I need a wider breadth of test articles to fully map out the issue as it seems the default bit mode can vary between models. I have a QHY5III174M on a telescope at the moment, so I will get that and use it as another data point.

bwdev01 commented 1 month ago

Ok, that makes sense. We appreciate the help on this – I was mostly concerned that you might have gotten fouled up with GitHub and inadvertently lost some work. It might be necessary to wait for QHY to clean up the implementation. For example, the slow performance in 8-bit mode sounds like a bug and if their ASCOM driver worked correctly in both modes, users could just rely on that.

Thanks,

Bruce

From: Dale Ghent @. Sent: Thursday, October 10, 2024 7:58 AM To: OpenPHDGuiding/phd2 @.> Cc: bwdev01 @.>; Comment @.> Subject: Re: [OpenPHDGuiding/phd2] Want bit mode selection for QHY cameras (#1245) (PR #1246)

Hi Bruce, I was testing some additional QHY models I had on hand and realized that fixing this issue may be more fraught than first realized. It's possible we may be looking at an unavoidable breaking change from some but perhaps not all QHY native driver users here. I am testing with a QHY5III462C and QHY183M currently. I feel that I need a wider breadth of test articles to fully map out the issue as it seems the default bit mode can vary between models. I have a QHY5III174M on a telescope at the moment, so I will get that and use it as another data point.

— Reply to this email directly, view it on GitHub https://github.com/OpenPHDGuiding/phd2/pull/1246#issuecomment-2405364561 , or unsubscribe https://github.com/notifications/unsubscribe-auth/ADDHSVYFQLUXBIPXNQMXAITZ22IVXAVCNFSM6AAAAABPV45CRCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDIMBVGM3DINJWGE . You are receiving this because you commented. https://github.com/notifications/beacon/ADDHSV5OEBABT4SBGCN3ZJTZ22IVXA5CNFSM6AAAAABPV45CRCWGG33NNVSW45C7OR4XAZNMJFZXG5LFINXW23LFNZ2KUY3PNVWWK3TUL5UWJTUPL3ZVC.gif Message ID: @. @.> >

daleghent commented 1 month ago

If you don't mind, I'll continue the discussion over on #1245 instead of this dead PR. Once I get some more testing done, I'll come up with a list of options.