search

OpenPHDGuiding / phd2

PHD2 Guiding
https://openphdguiding.org
BSD 3-Clause "New" or "Revised" License
255 stars 115 forks source link

Scope::CheckCalibrationDuration overriding calibration step size and user cannot override it #851

Closed agalasso closed 4 years ago

agalasso commented 4 years ago

https://groups.google.com/d/topic/open-phd-guiding/dUm9RYr-Umc/discussion

20:19:29.951 00.000 281472911574448 CalDuration adjusted at start of calibration from 1200 to 50 because of  mount guide speed  change

debug logs is here: https://openpphdguiding.org/save_logs/PHD2_logs_2XMS.zip

agalasso commented 4 years ago

@bwdev01 any idea how to fix this one?

bwdev01 commented 4 years ago

Well, the underlying problem is a buggy INDI driver for Celestron. It's reporting a mount guide speed of 0.208 degrees/sec or 749 arc-sec/sec. In the first calibration he did, the implied mount guide speeds were around 0.7x sidereal. A few possibilities come to mind: 1) add some sanity checking and only do the adjustment if the reported mount guide speed is sensible or 2) remove the checking altogether for changes in mount guide speed. The adjustment based on binning change is probably ok. This stuff works ok when the driver doesn't lie and to some extent, it's kind of "extra credit." We could let users sort it out for themselves if they change mount guide speeds without also adjusting the cal step-size. I'm open to suggestion on it.

Bruce

From: Andy Galasso [mailto:notifications@github.com] Sent: Saturday, March 28, 2020 10:23 PM To: OpenPHDGuiding/phd2 Cc: bwdev01; Mention Subject: Re: [OpenPHDGuiding/phd2] Scope::CheckCalibrationDuration overriding calibration step size and user cannot override it (#851)

@bwdev01 https://github.com/bwdev01 any idea how to fix this one?

You are receiving this because you were mentioned. Reply to this email directly, view https://github.com/OpenPHDGuiding/phd2/issues/851#issuecomment-605561098 it on GitHub, or unsubscribe https://github.com/notifications/unsubscribe-auth/ADDHSV3LEAZ32BP3Y4ZUNLTRJ 3LKHANCNFSM4LV24Z7A . https://github.com/notifications/beacon/ADDHSV3V3UFBPST7ZPCWSJLRJ3LKHA5CNFS M4LV24Z7KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEQMCCCQ .gif

agalasso commented 4 years ago

I think a sanity check on the rate, something like treating any rate > 2x sidereal as invalid (as if the rate is unknown) would fit the bill.

We should also report this to the INDI developers. Do you have a log snippet or something like that we could give them that demonstrates the problem?

pchev commented 4 years ago

Bruce, be careful that INDI do not return the guide speed in deg/sec like ASCOM but it is x sidereal. So to this is 0.208 x sidereal = 3 arcsec / sec.

agalasso commented 4 years ago

Thanks Patick, I think it really must be a bug in the Celestron INDI driver since PHD2 appears to be correctly converting the INDI rate (sidereal multiple) to ASCOM rate units (degrees per second) https://github.com/OpenPHDGuiding/phd2/blob/master/scope_indi.cpp#L811

pchev commented 4 years ago

Right, I not remembered this part.

I try the Celestron driver has it include a simulation mode. I think the problem is it report the value as "Guide rate % sidereal" so the value is 100x too big. For 0.5 x sidereal it report: Celestron GPS.GUIDE_RATE.GUIDE_RATE_WE=50 Celestron GPS.GUIDE_RATE.GUIDE_RATE_NS=50

This correspond to the 749 "/sec Bruce see in the log.

The telescope simulator and other driver give the value as: Telescope Simulator.GUIDE_RATE.GUIDE_RATE_WE=0.5 Telescope Simulator.GUIDE_RATE.GUIDE_RATE_NS=0.5

agalasso commented 4 years ago

aha! good find. Will you be submitting the INDI driver issue? If not, I can do it.

bwdev01 commented 4 years ago

This looks like the Wild West. Celestron reports a bad result, EQMOD gets the right result, Losmandy and iOptron report "unknown". That's just from scanning my hard drive for INDI mount data which is limited because I don't generally look at problems on Linux systems. I think the best approach is to weed these things out in the adjustment code and only handle things that make sense.

Bruce

From: Andy Galasso [mailto:notifications@github.com] Sent: Sunday, March 29, 2020 2:14 PM To: OpenPHDGuiding/phd2 Cc: bwdev01; Mention Subject: Re: [OpenPHDGuiding/phd2] Scope::CheckCalibrationDuration overriding calibration step size and user cannot override it (#851)

aha! good find. Will you be submitting the INDI driver issue? If not, I can do it.

You are receiving this because you were mentioned. Reply to this email directly, view https://github.com/OpenPHDGuiding/phd2/issues/851#issuecomment-605702601 it on GitHub, or unsubscribe https://github.com/notifications/unsubscribe-auth/ADDHSV3LDLPPM62LRMSWDVDRJ 623HANCNFSM4LV24Z7A . https://github.com/notifications/beacon/ADDHSV6TSNY6WEPCZYDVHOLRJ623HA5CNFS M4LV24Z7KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEQNETSI .gif