OpenPIV / openpiv-c--qt

C++ with Qt frontend (superfast) version of OpenPIV
http://www.openpiv.net
GNU General Public License v3.0
20 stars 17 forks source link

Windows VS2017 build Error #41

Closed VegetaZhang closed 1 year ago

VegetaZhang commented 1 year ago

Thank you for your selfless dedication. There are some compilation error issues that need to be consulted. My environment is Windows 10 and I use vs 2017 to build the code. I first built the vs2017 solution using 'cmake-B build-S'. Then I reported the following error while build openpivcore. I tried to correct the errors, but I could not fix them. If you have time, would you please provide some solutions? Thank you. image

VegetaZhang commented 1 year ago

​Here is the configuration of my project, ​We look forward to your reply, thank you. image

alexlib commented 1 year ago

@timdewhirst @ErichZimmer - do you have some experience with this error?

timdewhirst commented 1 year ago

Hello, and thanks for the report.

I suspect the issue is due to the old version of Visual Studio - it could be that not all C++17 features were correctly supported. I'll see if it's possible to reproduce using github's actions, but failing that, is it possible to upgrade to a newer version of Visual Studio?

VegetaZhang commented 1 year ago

Thank you for your advice. I will try to build with a new version of VS. If there is any progress, I will let everyone know again.

VegetaZhang commented 1 year ago

Good news, after switching to vs2022, it has been successfully built. Thank you again for your help. I think we can close this issue.

timdewhirst commented 1 year ago

great to hear, thanks for the update!