OpenPIV / openpiv-python

OpenPIV is an open source Particle Image Velocimetry analysis software written in Python and Cython
http://www.openpiv.net
GNU General Public License v3.0
233 stars 141 forks source link

suggestion: replace np.roll by scipy.ndimage.fourier_shift #258

Closed alexlib closed 1 year ago

alexlib commented 1 year ago

similar to https://scikit-image.org/docs/stable/auto_examples/registration/plot_register_translation.html#sphx-glr-auto-examples-registration-plot-register-translation-py

it will allow us to use subpixel shifts and more stable and accurate tests

ErichZimmer commented 1 year ago

Where do we use this? Only on tests and the basic theory notebook?

alexlib commented 1 year ago

only in tests. tests is our weakest point

ErichZimmer commented 1 year ago

I suppose I can add more tests, probably in a similar fashion to OpenPIV-Python-cxx, while implementing your idea.