Closed nepomnyi closed 3 months ago
Hello, Dr. Liberzon @alexlib , I have just added this normalized median filter to windef.py
. If you choose to accept this pull request, I will send another one where the filter is added to windef.py
. Just letting you know in case anybody else was going to add it to windef.py
.
Thanks @nepomnyi, it’s rather clear and straightforward. Hope the users would find a great use for it. Please announce on the forum.
I added the function
local_norm_median_val()
tovalidation.py
. This function is the implementation of the normalized median filter given in the article J. Westerweel, F. Scarano, "Universal outlier detection for PIV data", Experiments in fluids, 39(6), p.1096-1100, 2005. This function complements the already existing functionlocal_median_val()
which is, essentially, the original Westerweel's median filter from 1994. Note that, as opposed tolocal_median_val()
, I am checking the threshold condition exactly like it is shown in the referenced article, i.e., via the mean square root concept - not via the boolean "OR". I added the test forlocal_norm_median_val()
as well. The test is calledtest_local_norm_median_validation()
and is located in the filetest_validation.py
. When I ran all the tests withpytest
, my test ran without errors or warnings. However, another test failed with the following error:FAILED test\test_preprocess.py::test_dynamic_masking - _tkinter.TclError: Can't find a usable tk.tcl in the following directories:
. I checked: I didn't do anything with the functiondynamic_masking()
. So, I am wondering if we can proceed with my pull request and deal with the failed test later.