OpenPLi / enigma2

Framebuffer based frontend for DVB functions on Linux settop boxes
GNU General Public License v2.0
151 stars 203 forks source link

[Harddisk] more readable device name #4027

Closed Dima73 closed 2 months ago

littlesat commented 2 months ago

The idea is good, but the coding looks bad…. Could be better streamlined.

WanWizard commented 2 months ago

That's @littlesat's idea of streamlining yes, but unreadable and difficult to debug. I hate complex one-liners that aren't needed... it has absolutely zero benefit, only downsides. :disappointed:

littlesat commented 2 months ago

It is not the one liner idea that I do not like but more the try/except stuff when one of the files to parse do not exist. Maybe just check if it exists instead. And indeed do if both exists then give a combined value if one exists give back a string and if none exists then return unknown.