search

OpenPTV / openptv

This is our central repository, holding only the community approved code and documentation
www.openptv.net
GNU Lesser General Public License v3.0
37 stars 28 forks source link

new segmentation test #203

Open alexlib opened 2 years ago

alexlib commented 2 years ago

@C73150N please add a new test to https://github.com/OpenPTV/openptv/blob/master/py_bind/test/test_segmentation.py

we test now in https://github.com/OpenPTV/openptv/blob/c249337413882b6aefa48ac1bc68c7767099f651/py_bind/test/test_segmentation.py#L36 the detection of two (1 pixel each) targets and check that there are 2 of them and then the first one is of the size 1 pixel. Actually it checks that it's 1 pixel in x, 1 pixel in y and 1 pixel in total.

Please add a new test in which an object is 3 x 2 pixels and we actually know which is x and which is y by the shape of that object, i.e. 

        img = np.array([
            [0,   0,   0,   0, 0],
            [0, 255,   250,   250, 0],
            [0,   251,   253,   0, 0],
            [0,   0,   0, 251, 0],
            [0,   0,   0,   0, 0]
        ], dtype=np.uint8)

something like this, maybe there's a bug in this image. But we need to start by small steps

So, please:

  1. fork this repo to your account
  2. add the test
  3. send us the pull request
CleisonManriqueAguirre commented 2 years ago

I did a pull request and a previous fork , but I have some error checks from github . Please , correct me if wrong . Actually, spyder have some bugs while debugging and it was an error from the version so I changed to pycharm and it better suits .