search

OpenParliamentTV / OpenParliamentTV-NEL

0 stars 1 forks source link

Find more people, parties, factions #29

Closed tammo0 closed 2 years ago

tammo0 commented 2 years ago

Improved queries to find more related and needed people, parties and factions

alexabruck commented 2 years ago

Many thanks @tammo0 for the improvements :-)

tammo0 commented 2 years ago

hey @alexabruck - sure, next time i will have this in mind. Sorry for the mess

alexabruck commented 2 years ago

Haha no mess at all, I'll add the mappings quickly!

alexabruck commented 2 years ago

@tammo0 Question: Doesn't Q11744698 include all parliamentary groupings, not just German ones?

tammo0 commented 2 years ago

Thats right. Some are foreign (like Q217975) and some are just not good documented or labeled at wikidata. With this addition i aim to include Q4316268 and Q327591 which are referenced in the people results. Not having these in the factions.json and/or parties.json, results in conflicts when importing media related to these factions or parties to openparilament.

As long as there is no media related to these misscraped parties/factions it doesn't affect the database of openparliament at all, so i see no problem having these miscategorized entities at our wikidata jsons.

The other way to deal with it would be something like i suggested in #28

alexabruck commented 2 years ago

That makes sense, thanks for clarifying!

alexabruck commented 2 years ago

Other option would be to add these 2 candidates manually, might be more explicit maybe?

tammo0 commented 2 years ago

Other option would be to add these 2 candidates manually, might be more explicit maybe?

was my first idea too, but with that we are more flexible in case something changes at wikidatas side now, i think.