search

OpenParsec / openparsec

GNU General Public License v2.0
51 stars 8 forks source link

Tribad/64bit #73

Closed tribad closed 2 years ago

tribad commented 2 years ago

This is an all-in-one pullrequest. So it contains all changes done for my 64-bit port. But different commits. As it is not that much that has changed should be easy to handle. The 64-Bit port loads the 32-Bit assets. But leaves the original objects in place to it would be possible to load 64-bit aware assets as well. But that was never tested by me.

uberlinuxguy commented 2 years ago

First pass, of a few probably, this looks very good. I've left a few comments on some stuff I have noticed. The tab stops seem to be all messed up in some places too, might be a good idea to fix that for consistency. We can't commit messed up tab stops that make this even harder to read.

uberlinuxguy commented 2 years ago

I also think this should probably be broken up into 3 prs. 1) the animation stuff. 2) the merging of the obj_odt 64 bit stuff and 3) the CMake stuff. That would allow the conversations to take place on each independently and have each part merged independently. Thoughts?

tribad commented 2 years ago

I give up on the formatting. I you dont like it, dont use it.

uberlinuxguy commented 2 years ago

Made some "suggestions" on the vertex animation code to fix the tab stops there. I think all you have to do is click "Commit Suggestion" if you are ok with it and that will fix it for you. I can look at the obj_odt code too and make the suggestions for changes as well, if you aren't opposed to that method.

uberlinuxguy commented 2 years ago

Ok, that got a bit over the top. I tried submitting change suggestions for all the tab stop fixes, but it got a bit out of hand.... I'm going to stop now and say if there are no further concerns, if the suggestions can be applied, and remaining comments be addressed, this is good to go and I'll fix the remaining tab stops after merge.

slime73 commented 2 years ago

I also think this should probably be broken up into 3 prs. 1) the animation stuff. 2) the merging of the obj_odt 64 bit stuff and 3) the CMake stuff. That would allow the conversations to take place on each independently and have each part merged independently. Thoughts?

Agreed - or at least the 64 bit+animation stuff should be a separate PR from the CMake and build system changes and from the GLEW change.