OpenPecha / Toolkit

🛠 Tools to create, edit and export texts and annotations
https://toolkit.openpecha.org
Apache License 2.0
7 stars 4 forks source link

fix(pecha): handle box rotation #214

Closed eroux closed 1 year ago

eroux commented 1 year ago

This:

eroux commented 1 year ago

@kaldan007 what do you think?

kaldan007 commented 1 year ago

What I was suggesting was that we hv two kind of order 43 12 and 41

  1. As of now we are using 1 and 2 to get width assuming we will be having the first order only. Since we discovered we hv two kind of order according to their orientation, hence i would suggest to use the diagonal veritices 1 and 3 to compute width n height.
eroux commented 1 year ago

ah, right, that makes sense. I made something a bit more sophisticated in this PR, it should be more robust

kaldan007 commented 1 year ago

I will make the changes n send pr

eroux commented 1 year ago

this PR solves that issue in another way, no need to make more changes

kaldan007 commented 1 year ago

Ok