OpenPeeDeeP / depguard

Go linter that checks if package imports are in a list of acceptable packages.
GNU General Public License v3.0
147 stars 16 forks source link

Update README with information on Allow/Deny List functionality #55

Closed dixonwille closed 1 year ago

dixonwille commented 1 year ago

It is unclear what an empty allow and deny list do. README should reflect this.

ianlewis commented 1 year ago

Currently it seems with golangci-lint 1.53+ that an empty allow (e.g. no depguard config) means that nothing is allowed. Pretty sure that changed from 1.52 as we didn't encounter errors before.

dixonwille commented 1 year ago

https://github.com/OpenPeeDeeP/depguard/issues/49

Yes the default behavior changed. Having no depguard config, but enabling it did absolutely nothing in depguard v1.

maqdev commented 1 year ago

Is there a way to allow everything by default, and only deny what's in deny list? Removing allow section doesn't help.

dixonwille commented 1 year ago

https://github.com/OpenPeeDeeP/depguard/pull/70

I believe this is what you are looking for. I still want to document it before merging it in.