search

OpenPerpetuum / OPDiscordBot

A repository featuring discord bot(s) designed to consume OpenPerpetuum API(s) to display and interact with the Perpetuum Discord.
1 stars 2 forks source link

Better/More Clear separation between kills in single message #5

Closed MikeJeffers closed 3 years ago

MikeJeffers commented 5 years ago

=======New Kill!========= is ok but doesn't cut it and is 'busy' Better use of whitespace?

Veritania commented 3 years ago

Could using the Discord Embeds feature be worth exploring? Example: embed-example

The embed example was quickly thrown together using https://cog-creators.github.io/discord-embed-sandbox/ , but I think you have even more control and options over the embed through code than this sandbox gives you.

For directly addressing the issue of this ticket, the red line in the example can get a random color pr message, so it's easier to see where one kill report starts/ends.

MikeJeffers commented 3 years ago

Yes, think something like this would be a good enhancement! Basically anything that is better communicating the information is a win. The embed is a nice idea because it will make layout data in 2D a little more maintainable, lines of text was our MVP 😆

Veritania commented 3 years ago

I gave it a shot, but ran into an issue that I can't quite figure out at the moment. Please have a look in PR #13 for more details, and examples of the current Embed Look :)

Next day Edit: Aforementioned issue has been fixed, sleep is magic.

Veritania commented 3 years ago

Solved with PR https://github.com/OpenPerpetuum/OPDiscordBot/pull/13