Fix player respawning in Terminal if not of owner corp (gamma) - Githubissues

OpenPerpetuum / PerpetuumServer

The Open Perpetuum Project's fork of the Perpetuum Standalone Server

https://openperpetuum.com

Other

44 stars 21 forks source link

Fix player respawning in Terminal if not of owner corp (gamma) #358

Closed MikeJeffers closed 3 years ago

MikeJeffers commented 3 years ago

Situation:

Player is member of Corp A which owns Gamma Terminal G
Player is kicked, or leaves Corp A but is still docked in G
Player undocks, shot by turrets/players, respawns in terminal G (vanilla behaviour)

Possible scenarios:

Player sets the terminal as homebase - should they continue to respawn there regardless of their relation with the owner? (is the terminal locked to them?)
- Player resets their homebase (set to null) - same question (this might be the player's desire to not respawn in that base anymore, and should fallback to "default" homebase TMA)

Fix/possible solutions:

When player is kicked, or is "locked out" of a terminal they set as their homebase, their homebase should be cleared too.
When a player respawns at the "last docking base" (the first strategy of a respawn with null-homebase) perform a check if the base is dockable for player - otherwise go to default TMA.

MikeJeffers commented 3 years ago

Works on current Development branch, not sure when this issue occurred with this fork.