New Player Starting NIC/EP

OpenPerpetuum / PerpetuumServer

The Open Perpetuum Project's fork of the Perpetuum Standalone Server

https://openperpetuum.com

Other

43 stars 21 forks source link

New Player Starting NIC/EP #459

Closed andrey-at-home closed 1 year ago

andrey-at-home commented 1 year ago

Pull request target #310 issues. I suggest using a config file pereptuum.ini for storing parameters:

using NIC/EP for new player from server config file, or default value if they are not specified in the file
using this solution for default value.

MikeJeffers commented 1 year ago

This is excellent. Good call putting in the ini, db probably overkill for loading constants. Defaults to ensure consistent behaviour with old inis really seals this as a safe PR to merge! Thank you for your contribution! 💯

Will do closer look and merge shortly, but no notes so far.

andrey-at-home commented 1 year ago

Was cleaning brunches and accidentally deleted this pull request :( Restored it.

MikeJeffers commented 1 year ago

Was cleaning brunches and accidentally deleted this pull request :( Restored it.

Thanks for that!
For now I'll merge it because it won't affect deployed code (to my knowledge) with or without your provided configuration options.

Also if you are looking to directly contribute/join the team, make sure the team knows you should be added to the org. I am not an active maintainer any longer, so the more that can directly contribute, review, and merge - the better!

MikeJeffers commented 1 year ago

Congrats on your first contribution to the OPP fork @aqpanaciy ! :tada: :rocket: