search

OpenPerpetuum / PerpetuumServer

The Open Perpetuum Project's fork of the Perpetuum Standalone Server
https://openperpetuum.com
Other
44 stars 21 forks source link

Weather jump #460

Closed aqpanaciy closed 1 year ago

aqpanaciy commented 1 year ago

I have noticed sharp changes in weather special effects when playing on the online server. It seems to be related to the maximum value (255) of the weather. Here is a comparison video of weather changes from 254 to 255 and from 0 to 254 when tested on a local server.

This is a video with a weather jump on an online server.

I propose here to limit the maximum value to 254.

MikeJeffers commented 1 year ago

Thank you for supplying video and logs with the issue, super informative and help others replicate! I did notice this too and debated clamping the weather bit to 254 to avoid this issue.. but we determined at the time it was really a client issue rather than the server - but given that was reported a while ago, maybe better to workaround it server side at this point.

Thank you for reporting!

aqpanaciy commented 1 year ago

Limiting the max value to 254 fixes the weather jumping issue, but reduces the chance of clear weather.