Closed sdasda7777 closed 1 year ago
New project still looks like this:
But after saving, or when opening previously saved file, the path is shown as well:
Thank you. The diffs for entire files seem like differences in line endings (or they usually are). I believe most files originally had CRLFs, but I wonder why only these were changed, to what line endings and why those with real changes are unaffected.
I see, definitely could be the case. Should I rebase it and leave out the "unmodified" files, then?
Yes, please do. Before you do, try to find what were the original and new line endings, please, so we can find out what can we do about that in the future (I fight with line endings sometimes as well).
As far as I can tell, it seems the files I modified already had Windows newlines, whereas the other ones had Unix newlines originally 🤔 Either way it's disappointing to see that Iceberg commited something that wasn't shown on the commit review screen at all 😢
Either way it's disappointing to see that Iceberg commited something that wasn't shown on the commit review screen at all 😢
Although, could it be possible one of the git hooks did it? I think not, since it would most likely require the Iceberg to commit changes to those files in the first place, but I'm not completely sure.
On topic of git, I think git has some setting for forcing a newline kind for a filetype: that might be a good idea to use.
(It seems you have to link issue from the PR, not the other way around: #80 )
Fixes #80 🤦♂️
(I don't know why there's so many changes, I only modified two or so lines, and the other files seem unchanged anyways)
Fixes #80 🤦♂️🤦♂️🤦♂️