search

OpenPonk / openponk

The OpenPonk modeling platform
https://openponk.github.io/
MIT License
43 stars 9 forks source link

[Bug] Note element text is not shown immediately #90

Closed sdasda7777 closed 1 year ago

sdasda7777 commented 1 year ago

I've noticed that when creating new Note element, the text only appears after clicking somewhere or moving the camera. Most likely there should be some update call happening right after creation and it isn't.

On the following picture, both elements have text, only for the second one it isn't shown yet.

image

sdasda7777 commented 1 year ago

Manually calling renderFigureIn: after updating the text seems to fix it, but I'm not sure if it is the correct solution.

image

JanBliznicenko commented 1 year ago

Well, I actually do not like have anything figure-related in this method at all, but that is story for another day :) For now, I think best solution would be to put text signalUpdate to the end of OPResizableFigureWithText>>#updateText. Sending signalUpdate to roassal element causes canvas to redraw and that is needed exactly when we update the text.

sdasda7777 commented 1 year ago

That is definitely much more elegant, thanks!