Fixed issues reported by RH coverity tool

[zdohnal]

Hi Till!

This is the last batch of coverity fixes after the rebase :) would you mind merging it?

[tillkamppeter]

Now I get several warnings:

$ make
make  all-recursive
make[1]: Entering directory '/home/till/printing/openprinting/cups-browsed/x'
make[2]: Entering directory '/home/till/printing/openprinting/cups-browsed/x'
  CC       daemon/cups_browsed-cups-browsed.o
daemon/cups-browsed.c: In function ‘create_remote_printer_entry’:
daemon/cups-browsed.c:7720:10: warning: passing argument 1 of ‘free’ discards ‘const’ qualifier from pointer target type [-Wdiscarded-qualifiers]
 7720 |     free(resource);
      |          ^~~~~~~~
In file included from daemon/cups-browsed.c:31:
/usr/include/stdlib.h:568:25: note: expected ‘void *’ but argument is of type ‘const char *’
  568 | extern void free (void *__ptr) __THROW;
      |                   ~~~~~~^~~~~
daemon/cups-browsed.c:7721:10: warning: passing argument 1 of ‘free’ discards ‘const’ qualifier from pointer target type [-Wdiscarded-qualifiers]
 7721 |     free(service_name);
      |          ^~~~~~~~~~~~
/usr/include/stdlib.h:568:25: note: expected ‘void *’ but argument is of type ‘const char *’
  568 | extern void free (void *__ptr) __THROW;
      |                   ~~~~~~^~~~~
daemon/cups-browsed.c:7722:10: warning: passing argument 1 of ‘free’ discards ‘const’ qualifier from pointer target type [-Wdiscarded-qualifiers]
 7722 |     free(type);
      |          ^~~~
/usr/include/stdlib.h:568:25: note: expected ‘void *’ but argument is of type ‘const char *’
  568 | extern void free (void *__ptr) __THROW;
      |                   ~~~~~~^~~~~
daemon/cups-browsed.c:7723:10: warning: passing argument 1 of ‘free’ discards ‘const’ qualifier from pointer target type [-Wdiscarded-qualifiers]
 7723 |     free(domain);
      |          ^~~~~~
/usr/include/stdlib.h:568:25: note: expected ‘void *’ but argument is of type ‘const char *’
  568 | extern void free (void *__ptr) __THROW;
      |                   ~~~~~~^~~~~
daemon/cups-browsed.c: In function ‘create_queue’:
daemon/cups-browsed.c:8493:12: warning: passing argument 1 of ‘free’ discards ‘const’ qualifier from pointer target type [-Wdiscarded-qualifiers]
 8493 |       free(loadedppd);
      |            ^~~~~~~~~
/usr/include/stdlib.h:568:25: note: expected ‘void *’ but argument is of type ‘const char *’
  568 | extern void free (void *__ptr) __THROW;
      |                   ~~~~~~^~~~~
daemon/cups-browsed.c:8510:17: warning: passing argument 1 of ‘free’ discards ‘const’ qualifier from pointer target type [-Wdiscarded-qualifiers]
 8510 |            free(loadedppd);
      |                 ^~~~~~~~~
/usr/include/stdlib.h:568:25: note: expected ‘void *’ but argument is of type ‘const char *’
  568 | extern void free (void *__ptr) __THROW;
      |                   ~~~~~~^~~~~
daemon/cups-browsed.c:8649:10: warning: passing argument 1 of ‘free’ discards ‘const’ qualifier from pointer target type [-Wdiscarded-qualifiers]
 8649 |     free(loadedppd);
      |          ^~~~~~~~~
/usr/include/stdlib.h:568:25: note: expected ‘void *’ but argument is of type ‘const char *’
  568 | extern void free (void *__ptr) __THROW;
      |                   ~~~~~~^~~~~
  CCLD     cups-browsed
$

Can they be caused by the Coverity fixes?

[zdohnal]

Damn, they are - preparing a PR to fix it.

[zdohnal]

The PR was created - I'm sorry for inconvenience.