search

OpenPrinting / cups

OpenPrinting CUPS Sources
https://openprinting.github.io/cups
Apache License 2.0
967 stars 177 forks source link

scheduler: Set reasons in cupsdSetJobState only if we call finalize_j… #832

Closed zdohnal closed 7 months ago

zdohnal commented 7 months ago

…ob later

Before the fix, every successfully printed jobs ended up with 'processing-to-stop-point' as the last reasons message.

Together with #830 fixes #828 .

zdohnal commented 7 months ago

I'll just make one change - we have to be sure that we have 'job' before calling the ippSetString, since we dereference it - I blindly negated the conditions which have to be fulfilled to get to finalize_job() and we shouldn't get here if job is NULL, but just to make sure that it is clear we have to have job there...