OpenPrinting / ippusbxd

Cross-platform IPP over USB driver
Other
29 stars 4 forks source link

1.34 release ? #16

Closed OdyX closed 4 years ago

OdyX commented 4 years ago

There are a lot if improvements on top of 1.33; care to release ?

tillkamppeter commented 4 years ago

OK, I will release soon. But note that ippusbxd has important architectural deficiencies an it is recommended to use ipp-usb instead. It is written n Go and therefore the executable is larger but this should not be a problem on modern systems. I highly recommend to use that one in Debian. One of the deficiencies of ippusbxd, not the most important though, is that the DNS-SD advertising of ippusbxd is hard-coded and does not represent actual devices, especially cannot cope with whether the device has a scanner or not. @ordissimo has promised to fix this by asking the device on daemon startup (like it works in ipp-usb now) in February. Should I perhaps wait for this with a release?

ThierryHFR commented 4 years ago

Le 2020-01-31 17:49, Till Kamppeter a écrit :

OK, I will release soon. But note that ippusbxd has important architectural deficiencies an it is recommended to use ipp-usb [1] instead. It is written n Go and therefore the executable is larger but this should not be a problem on modern systems. I highly recommend to use that one in Debian. One of the deficiencies of ippusbxd, not the most important though, is that the DNS-SD advertising of ippusbxd is hard-coded and does not represent actual devices, especially cannot cope with whether the device has a scanner or not. @Ordissimo [2] has promised to fix this by asking the device on daemon startup (like it works in ipp-usb now) in February. Should I perhaps wait for this with a release? Hi @till.kamppeter, I would push a patch very soon. The idea of recovering the data in the capabilites file is excellent. The DNS-SD interface will be dynamic and device specific.

-- You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub [3], or unsubscribe [4].

Links:

[1] https://github.com/alexpevzner/ipp-usb/ [2] https://github.com/Ordissimo [3] https://github.com/OpenPrinting/ippusbxd/issues/16?email_source=notifications&email_token=ACRQEDFONIEUMLJ3N2DPCFLRARJBZA5CNFSM4KOI3KI2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEKPIM6A#issuecomment-580814456 [4] https://github.com/notifications/unsubscribe-auth/ACRQEDCCPVQRIOQWOXNYK2DRARJBZANCNFSM4KOI3KIQ

tillkamppeter commented 4 years ago

@Ordissimo, any plans when you will post your Pull Request?

ThierryHFR commented 4 years ago

Hi @tillkamppeter, I'll propose a fix by Monday.

tillkamppeter commented 4 years ago

@DavieV, @OdyX, please test the additions from @Ordissimo for the DNS-SD advertising of the device. Is this all OK for you? Then I will do the 1.34 release.

tillkamppeter commented 4 years ago

Done: https://github.com/OpenPrinting/ippusbxd/releases/tag/1.34 Commit: 2b060a9 Thank you very much to everyone who has contributed!