search

OpenPrinting / libcupsfilters

Apache License 2.0
5 stars 22 forks source link

replaced PointerHolder with shared_ptr #13

Closed ShivamIITK21 closed 1 year ago

ShivamIITK21 commented 1 year ago

PointerHolder is deprecated in the qpdf v11, getting replaced with std::shared_ptr. Warnings should be fixed with qpdf v12 onwards.

tillkamppeter commented 1 year ago

Thank you very much.

Did you compile the code? Does it completely compile without producing any errors or warnings except the PointerHolder warnings?

ShivamIITK21 commented 1 year ago

Yes I did compile it on Ubuntu Lunar, the only warnings are PointerHolder warnings

tillkamppeter commented 1 year ago

Ran some filters for testing and all seems to be OK. Thank you very much.

sourabh1952 commented 1 year ago

err.txt

@ShivamIITK21 @tillkamppeter when I used the make command it gives me this error.I update qpdf but the newest version is (10.6.3-1). can you please tell me how to update qpdf to v12 because I deleted the old repo of libcupsfilters and I have to install libcupsfilters now from the updated repo but it gives me the above error.

ShivamIITK21 commented 1 year ago

You can build qpdf v11 from source, https://github.com/qpdf/qpdf