search

OpenPrinting / libppd

Apache License 2.0
2 stars 13 forks source link

build: fix failure to correctly link to zlib #32

Closed eli-schwartz closed 5 months ago

eli-schwartz commented 8 months ago

Checking for the header is NOT sufficient when utilizing its shared library symbols. Look it up with pkg-config explicitly, and explicitly add it to ensure that at runtime, libppd has its own DT_NEEDED dependency on libz.so; if libppd successfully links at all -- not a given, if -Wl,-no-undefined is used -- then it may transitively get libz.so from its recursive dependencies, but this is no guarantee at all.

Fixes failure to build discovered at https://bugs.gentoo.org/920273

tillkamppeter commented 5 months ago

Thanks a lot for the fix, and sorry for having overlooked it in the first place.

eli-schwartz commented 5 months ago

No big deal, the important thing is to get it in before the next tagged release.