search

OpenPrinting / openprinting.github.io

Organization Pages for OpenPrinting
Apache License 2.0
12 stars 25 forks source link

Add auto-dark mode CSS. #122

Closed michaelrsweet closed 3 years ago

michaelrsweet commented 3 years ago

This pull request implements an automatic dark mode for the OpenPrinting web site, which looks like this:

Screen Shot 2020-12-16 at 2 56 40 PM Screen Shot 2020-12-16 at 2 57 59 PM
tillkamppeter commented 3 years ago

Can the user switch between light and dark mode, like on dpreview? Or does it switch automatically, with the theme of the user's browser or phone?

michaelrsweet commented 3 years ago

@tillkamppeter It switches automatically based on the local theme (light or dark). Doing a manual override would require some Javascript intervention, and IMHO it isn't worth the effort. My goal is simply to go with the user's intent (light/dark for the system) and not to make the web site ultra-configurable.

tillkamppeter commented 3 years ago

OK, that's great. Approved.