OpenPrinting / openprinting.github.io

Organization Pages for OpenPrinting
Apache License 2.0
12 stars 25 forks source link

CUPS project page - CSS issues #124

Closed dheeraj135 closed 3 years ago

dheeraj135 commented 3 years ago

CUPS logo dimensions on this page need to be corrected. The current size is too large.

Screenshot from 2021-02-21 22-42-43

tillkamppeter commented 3 years ago

For me the logo is still huge in Chromium (of Ubuntu Hirsute) and correct in Firefox.

But should this issue not get removed to the CUPS repository as the CUPS site is coming from there.

tillkamppeter commented 3 years ago

@michaelrsweet ?

michaelrsweet commented 3 years ago

@tillkamppeter @dheeraj135 Weird, I didn't see this when I tested against Chrome, but I'll add explicit dimensions to the HTML template since it obviously isn't picking up the dimensions from the CSS...

michaelrsweet commented 3 years ago

[gh-pages ada14b693] Add HTML image dimensions to fix Chrome rendering bug.

May take a few minutes to sync up on github.io...

michaelrsweet commented 3 years ago

I updated chrome and am getting the same issue, even with the dimensions being specified in the HTML!

Definitely a Chrome bug, and after much experimentation it only happens when you specify the source in CSS, so I've pushed a change that moves that to the HTML...

[gh-pages 59641bc86] Don't use CSS for the navbar icon, as Chrome has a major rendering bug. Just use plain HTML.

michaelrsweet commented 3 years ago

[gh-pages b86979729] Fix search controls for Chrome...

michaelrsweet commented 3 years ago

OK, seems to be rendering consistently between Chrome, Firefox, and Safari for me...

tillkamppeter commented 3 years ago

OK, now it works for me.

dheeraj135 commented 3 years ago

It's now working for me. Thanks @michaelrsweet .